From: Jerome Loyet <fat@php.net>
Date: Wed, 23 May 2012 09:30:27 +0000 (+0200)
Subject: - Fixed bug #61295 (php-fpm should not fail with commented 'user' for non-root start)
X-Git-Tag: php-5.4.4RC2~36^2~5
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=812d2481935185eeeabb2c1fe2d7eafd76fc7359;p=php

- Fixed bug #61295 (php-fpm should not fail with commented 'user' for non-root start)
---

diff --git a/NEWS b/NEWS
index c1d5f618b0..13ac964518 100644
--- a/NEWS
+++ b/NEWS
@@ -7,6 +7,8 @@ PHP                                                                        NEWS
 - FPM
   . Fixed bug #61045 (fpm don't send error log to fastcgi clients). (fat)
 	. Fixed bug #61835 (php-fpm is not allowed to run as root). (fat)
+  . Fixed bug #61295 (php-fpm should not fail with commented 'user'
+    for non-root start). (fat)
 
 - XML Writer:
   . Fixed bug #62064 (memory leak in the XML Writer module). 
diff --git a/sapi/fpm/fpm/fpm_conf.c b/sapi/fpm/fpm/fpm_conf.c
index 304076d35e..0b2c5aef5a 100644
--- a/sapi/fpm/fpm/fpm_conf.c
+++ b/sapi/fpm/fpm/fpm_conf.c
@@ -723,8 +723,8 @@ static int fpm_conf_process_all_pools() /* {{{ */
 			}
 		}
 
-		/* user */
-		if (!wp->config->user) {
+		/* alert if user is not set only if we are not root*/
+		if (!wp->config->user && !geteuid()) {
 			zlog(ZLOG_ALERT, "[pool %s] user has not been defined", wp->config->name);
 			return -1;
 		}