From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed, 26 Dec 2018 20:30:10 +0000 (-0500)
Subject: Fix portability failure introduced in commits d2b0b60e7 et al.
X-Git-Tag: REL9_6_12~52
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=811821748b5b833766444325c105b4bc25aac847;p=postgresql

Fix portability failure introduced in commits d2b0b60e7 et al.

I made a frontend fprintf() format use %m, forgetting that that's only
safe in HEAD not the back branches; prior to 96bf88d52 and d6c55de1f,
it would work on glibc platforms but not elsewhere.  Revert to using
%s ... strerror(errno) as the code did before.

We could have left HEAD as-is, but for code consistency across branches,
I chose to apply this patch there too.

Per Coverity and a few buildfarm members.
---

diff --git a/src/common/psprintf.c b/src/common/psprintf.c
index 53cee23fa9..93daeda552 100644
--- a/src/common/psprintf.c
+++ b/src/common/psprintf.c
@@ -131,7 +131,8 @@ pvsnprintf(char *buf, size_t len, const char *fmt, va_list args)
 #ifndef FRONTEND
 		elog(ERROR, "vsnprintf failed: %m with format string \"%s\"", fmt);
 #else
-		fprintf(stderr, "vsnprintf failed: %m with format string \"%s\"\n", fmt);
+		fprintf(stderr, "vsnprintf failed: %s with format string \"%s\"\n",
+				strerror(errno), fmt);
 		exit(EXIT_FAILURE);
 #endif
 	}