From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Sat, 26 Feb 2022 19:20:56 +0000 (-0800)
Subject: expr exeval: [nfc] remove unnecessary parens, dereference of function pointers
X-Git-Tag: 4.0.0~204^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=807f4d1bb4499b7e5f2767a52df686251301ff60;p=graphviz

expr exeval: [nfc] remove unnecessary parens, dereference of function pointers

The C compiler knows how to dereference and call through a function pointer
without needing this manual instruction.
---

diff --git a/lib/expr/exeval.c b/lib/expr/exeval.c
index dfcfa3fe4..77bc82bc5 100644
--- a/lib/expr/exeval.c
+++ b/lib/expr/exeval.c
@@ -2062,13 +2062,13 @@ exeval(Expr_t* ex, Exnode_t* expr, void* env)
 		switch (expr->type)
 		{
 		case FLOATING:
-			v.floating = (*expr->compiled.floating)(ex->disc->data);
+			v.floating = expr->compiled.floating(ex->disc->data);
 			break;
 		case STRING:
-			v.string = (*expr->compiled.string)(ex->disc->data);
+			v.string = expr->compiled.string(ex->disc->data);
 			break;
 		default:
-			v.integer = (*expr->compiled.integer)(ex->disc->data);
+			v.integer = expr->compiled.integer(ex->disc->data);
 			break;
 		}
 	}