From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Sun, 16 Apr 2000 01:55:45 +0000 (+0000)
Subject: get_relattval() should treat a NULL constant as a non-constant expression,
X-Git-Tag: REL7_0~121
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=8064a49f6f8e38aa0ba0fd46c6903ea513014446;p=postgresql

get_relattval() should treat a NULL constant as a non-constant expression,
since it has no way to indicate to its caller that the constant is
actually NULL.  This prevents coredump in cases like
  WHERE textfield < null::text;
---

diff --git a/src/backend/optimizer/util/clauses.c b/src/backend/optimizer/util/clauses.c
index 7ddbe4190c..0404dce938 100644
--- a/src/backend/optimizer/util/clauses.c
+++ b/src/backend/optimizer/util/clauses.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/optimizer/util/clauses.c,v 1.65 2000/04/12 17:15:24 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/optimizer/util/clauses.c,v 1.66 2000/04/16 01:55:45 tgl Exp $
  *
  * HISTORY
  *	  AUTHOR			DATE			MAJOR EVENT
@@ -790,7 +790,8 @@ default_results:
 
 	other = (*flag == 0) ? left : right;
 
-	if (IsA(other, Const))
+	if (IsA(other, Const) &&
+		!((Const *) other)->constisnull)
 	{
 		*constval = ((Const *) other)->constvalue;
 		*flag |= SEL_CONSTANT;