From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 15 Apr 2015 15:43:58 +0000 (-0700)
Subject: parse_date_basic(): return early when given a bogus timestamp
X-Git-Tag: v2.3.8~4^2~1
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=7fcec48da90f95dc64268ebd4b3073ae9487fe4e;p=git

parse_date_basic(): return early when given a bogus timestamp

When the input does not have GMT timezone offset, the code computes
it by computing the local and GMT time for the given timestamp. But
there is no point doing so if the given timestamp is known to be a
bogus one.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/date.c b/date.c
index 782de95d90..76fb47518d 100644
--- a/date.c
+++ b/date.c
@@ -696,6 +696,9 @@ int parse_date_basic(const char *date, unsigned long *timestamp, int *offset)
 
 	/* mktime uses local timezone */
 	*timestamp = tm_to_time_t(&tm);
+	if (*timestamp == -1)
+		return -1;
+
 	if (*offset == -1) {
 		time_t temp_time = mktime(&tm);
 		if ((time_t)*timestamp > temp_time) {
@@ -705,9 +708,6 @@ int parse_date_basic(const char *date, unsigned long *timestamp, int *offset)
 		}
 	}
 
-	if (*timestamp == -1)
-		return -1;
-
 	if (!tm_gmt)
 		*timestamp -= *offset * 60;
 	return 0; /* success */