From: Bram Moolenaar <Bram@vim.org>
Date: Mon, 7 Aug 2017 20:08:05 +0000 (+0200)
Subject: patch 8.0.0891: uninitialized memory use with empty line in terminal
X-Git-Tag: v8.0.0891
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=7fadbf83256bb823b994a52758127594dd82ab39;p=vim

patch 8.0.0891: uninitialized memory use with empty line in terminal

Problem:    Uninitialized memory use with empty line in terminal.
Solution:   Initialize growarray earlier. (Yasuhiro Matsumoto, closes #1949)
---

diff --git a/src/terminal.c b/src/terminal.c
index 7029f49ab..9743468f2 100644
--- a/src/terminal.c
+++ b/src/terminal.c
@@ -1346,11 +1346,11 @@ handle_pushline(int cols, const VTermScreenCell *cells, void *user)
 	    if (cells[i].chars[0] != 0)
 		len = i + 1;
 
+	ga_init2(&ga, 1, 100);
 	if (len > 0)
 	    p = (cellattr_T *)alloc((int)sizeof(cellattr_T) * len);
 	if (p != NULL)
 	{
-	    ga_init2(&ga, 1, 100);
 	    for (col = 0; col < len; col += cells[col].width)
 	    {
 		if (ga_grow(&ga, MB_MAXBYTES) == FAIL)
diff --git a/src/version.c b/src/version.c
index 0873d25e9..6b33c3bb6 100644
--- a/src/version.c
+++ b/src/version.c
@@ -769,6 +769,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    891,
 /**/
     890,
 /**/