From: Matt Wilmas <mattwil@php.net>
Date: Tue, 17 Mar 2009 00:02:39 +0000 (+0000)
Subject: Removed unneeded HashPosition variable (php_implode() doesn't change the internal... 
X-Git-Tag: php-5.3.0RC1~69
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=7f373057efd66cefbfa2bfa88631fc4907f299d2;p=php

Removed unneeded HashPosition variable (php_implode() doesn't change the internal pointer)
- It was added in '06 with the "200-300%" implode() optimization (hasn't been merged to HEAD)
---

diff --git a/ext/standard/string.c b/ext/standard/string.c
index f1927aa127..458cd4d3ac 100644
--- a/ext/standard/string.c
+++ b/ext/standard/string.c
@@ -1130,7 +1130,6 @@ PHPAPI void php_implode(zval *delim, zval *arr, zval *return_value TSRMLS_DC)
 PHP_FUNCTION(implode)
 {
 	zval **arg1 = NULL, **arg2 = NULL, *delim, *arr;
-	HashPosition pos;
 
 	if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "Z|Z", &arg1, &arg2) == FAILURE) {
 		return;
@@ -1162,13 +1161,9 @@ PHP_FUNCTION(implode)
 			return;
 		}
 	}
-
-	pos = Z_ARRVAL_P(arr)->pInternalPointer;
 	
 	php_implode(delim, arr, return_value TSRMLS_CC);
 
-	Z_ARRVAL_P(arr)->pInternalPointer = pos;
-
 	if (arg2 == NULL) {
 		FREE_ZVAL(delim);
 	}