From: Bruce Momjian <bruce@momjian.us>
Date: Thu, 8 Dec 2005 18:04:38 +0000 (+0000)
Subject: I recently received the Debian bug report below about missing iconv
X-Git-Tag: REL8_1_1~21
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=7f155c3322cb8e40f589be270d2eeebfbddfad23;p=postgresql

I recently received the Debian bug report below about missing iconv
support for the dbf2pg contrib module.

The submitter created a patch which replaces the silent ignoring of -F
(when iconv support is disabled) with a meaningful warning.

Martin Pitt
---

diff --git a/contrib/dbase/dbf2pg.c b/contrib/dbase/dbf2pg.c
index 7d42798dbe..50948a6bf2 100644
--- a/contrib/dbase/dbf2pg.c
+++ b/contrib/dbase/dbf2pg.c
@@ -618,10 +618,14 @@ main(int argc, char **argv)
 			case 'U':
 				username = (char *) strdup(optarg);
 				break;
-#ifdef HAVE_ICONV_H
 			case 'F':
+#ifdef HAVE_ICONV_H
 				charset_from = (char *) strdup(optarg);
+#else
+				printf("WARNING: dbf2pg was compiled without iconv support, ignoring -F option\n");
+#endif
 				break;
+#ifdef HAVE_ICONV_H
 			case 'T':
 				charset_to = (char *) strdup(optarg);
 				break;