From: Aaron Ballman Date: Mon, 11 May 2015 14:09:50 +0000 (+0000) Subject: Disable __has_cpp_attribute when not compiling in C++ mode. As this feature test... X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=7ef43194f52cf6d14dd5511acfbc89a2f160cacf;p=clang Disable __has_cpp_attribute when not compiling in C++ mode. As this feature test macro only supports C++ style attributes, it doesn't apply to code compiled as C code, and can lead to diagnostics when given a scoped attribute. This addresses PR23435. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@236996 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Lex/PPMacroExpansion.cpp b/lib/Lex/PPMacroExpansion.cpp index 5af0205af3..87a07a43d0 100644 --- a/lib/Lex/PPMacroExpansion.cpp +++ b/lib/Lex/PPMacroExpansion.cpp @@ -283,7 +283,11 @@ void Preprocessor::RegisterBuiltinMacros() { Ident_Pragma = RegisterBuiltinMacro(*this, "_Pragma"); // C++ Standing Document Extensions. - Ident__has_cpp_attribute = RegisterBuiltinMacro(*this, "__has_cpp_attribute"); + if (LangOpts.CPlusPlus) + Ident__has_cpp_attribute = + RegisterBuiltinMacro(*this, "__has_cpp_attribute"); + else + Ident__has_cpp_attribute = nullptr; // GCC Extensions. Ident__BASE_FILE__ = RegisterBuiltinMacro(*this, "__BASE_FILE__"); diff --git a/test/Preprocessor/has_attribute.c b/test/Preprocessor/has_attribute.c index 0ef5b4857a..1a3c2a0e18 100644 --- a/test/Preprocessor/has_attribute.c +++ b/test/Preprocessor/has_attribute.c @@ -1,4 +1,4 @@ -// RUN: %clang_cc1 -triple arm-unknown-linux -E %s -o - | FileCheck %s +// RUN: %clang_cc1 -triple arm-unknown-linux -verify -E %s -o - | FileCheck %s // CHECK: always_inline #if __has_attribute(always_inline) @@ -53,3 +53,6 @@ int has_no_volatile_attribute(); #if !__has_attribute(uuid) int does_not_have_uuid #endif + +#if __has_cpp_attribute(selectany) // expected-error {{token is not a valid binary operator in a preprocessor subexpression}} +#endif