From: Bruce Momjian <bruce@momjian.us>
Date: Wed, 13 Oct 1999 02:26:37 +0000 (+0000)
Subject: BLOBs containing NUL characters (ASCII 0) can be written to the
X-Git-Tag: REL7_0~1313
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=7ee7ee1398acb2ba8e1738a4d959025e43df8820;p=postgresql

BLOBs containing NUL characters (ASCII 0) can be written to the
database, but they get truncated at the first NUL by lo_read
when they are read back. The reason for this is that lo_read in
Pg.xs is using the default:
    OUTPUT:
        RETVAL
        buf
which uses C's strlen() to work out the length of the scalar.

The code ought to read something more like:
    OUTPUT:
        RETVAL
        buf sv_setpvn((SV*)ST(2), buf, RETVAL);

I am not sure if this needs to be done on both lo_read methods
in this file, but I changed both and have not since had any
problems with truncated BLOBs.

Douglas Thomson <dougt@mugc.cc.monash.edu.au>
---

diff --git a/src/interfaces/perl5/Pg.xs b/src/interfaces/perl5/Pg.xs
index 5419130a52..2c884c9c03 100644
--- a/src/interfaces/perl5/Pg.xs
+++ b/src/interfaces/perl5/Pg.xs
@@ -1,6 +1,6 @@
 /*-------------------------------------------------------
  *
- * $Id: Pg.xs,v 1.12 1999/02/19 23:27:17 tgl Exp $
+ * $Id: Pg.xs,v 1.13 1999/10/13 02:26:37 momjian Exp $ with patch for NULs
  *
  * Copyright (c) 1997, 1998  Edmund Mergl
  *
@@ -643,7 +643,7 @@ lo_read(conn, fd, buf, len)
 		}
 	OUTPUT:
 		RETVAL
-		buf
+		buf sv_setpvn((SV*)ST(2), buf, RETVAL);   /* to handle NULs */
 
 int
 lo_write(conn, fd, buf, len)
@@ -1029,7 +1029,7 @@ lo_read(conn, fd, buf, len)
 		}
 	OUTPUT:
 		RETVAL
-		buf
+		buf sv_setpvn((SV*)ST(2), buf, RETVAL);   /* to handle NULs */
 
 
 int