From: Steve Holme <steve_holme@hotmail.com>
Date: Fri, 18 Mar 2016 07:19:31 +0000 (+0000)
Subject: formdata.c: Fixed compilation warning
X-Git-Tag: curl-7_48_0~26
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=7e312bdfddb8135df49e6da8e7759f26ebdf4fa3;p=curl

formdata.c: Fixed compilation warning

formdata.c:390: warning: cast from pointer to integer of different size

Introduced in commit ca5f9341ef this happens because a char*, which is
32-bits wide in 32-bit land, is being cast to a curl_off_t which is
64-bits wide where 64-bit integers are supported by the compiler.

This doesn't happen in 64-bit land as a pointer is the same size as a
curl_off_t.

This fix doesn't address the fact that a 64-bit value cannot be used
for CURLFORM_CONTENTLEN when set in a form array and compiled on a
32-bit platforms, it does at least suppress the compilation warning.
---

diff --git a/lib/formdata.c b/lib/formdata.c
index 454be7610..c241e6e9b 100644
--- a/lib/formdata.c
+++ b/lib/formdata.c
@@ -387,7 +387,7 @@ CURLFORMcode FormAdd(struct curl_httppost **httppost,
     case CURLFORM_CONTENTLEN:
       current_form->flags |= CURL_HTTPPOST_LARGE;
       current_form->contentslength =
-        array_state?(curl_off_t)array_value:va_arg(params, curl_off_t);
+        array_state?(curl_off_t)(size_t)array_value:va_arg(params, curl_off_t);
       break;
 
       /* Get contents from a given file name */