From: Philip Reames Date: Sat, 13 Apr 2019 22:12:56 +0000 (+0000) Subject: [Tests] Add tests for D60659, and make adjustments to others to make diff clear X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=7e1fbc121730c826453fa2169ec80d981bd9c00c;p=llvm [Tests] Add tests for D60659, and make adjustments to others to make diff clear Three related changes: 1) auto-gen several test files 2) Add the new tests at the bottom of said files 3) Adjust a couple of other test files not to use stores to constants when trying to test constexpr address handling git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@358344 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/test/Transforms/InstCombine/gep-custom-dl.ll b/test/Transforms/InstCombine/gep-custom-dl.ll index 7c489e98814..e22653042a3 100644 --- a/test/Transforms/InstCombine/gep-custom-dl.ll +++ b/test/Transforms/InstCombine/gep-custom-dl.ll @@ -8,8 +8,7 @@ target datalayout = "e-m:m-p:40:64:64:32-i32:32-i16:16-i8:8-n32" %struct.C = type { [7 x i8] } -@Global = constant [10 x i8] c"helloworld" - +@Global = external global [10 x i8] ; Test that two array indexing geps fold define i32* @test1(i32* %I) { diff --git a/test/Transforms/InstCombine/getelementptr.ll b/test/Transforms/InstCombine/getelementptr.ll index ebd5f57e48b..566e15f2893 100644 --- a/test/Transforms/InstCombine/getelementptr.ll +++ b/test/Transforms/InstCombine/getelementptr.ll @@ -9,8 +9,8 @@ target datalayout = "e-p:64:64-p1:16:16-p2:32:32:32-p3:64:64:64" %struct.C = type { [7 x i8] } -@Global = constant [10 x i8] c"helloworld" -@Global_as1 = addrspace(1) constant [10 x i8] c"helloworld" +@Global = external global [10 x i8] +@Global_as1 = external addrspace(1) global [10 x i8] ; Test noop elimination define i32* @test1(i32* %I) { diff --git a/test/Transforms/InstCombine/memcpy.ll b/test/Transforms/InstCombine/memcpy.ll index ecdcae0a580..1adb815f612 100644 --- a/test/Transforms/InstCombine/memcpy.ll +++ b/test/Transforms/InstCombine/memcpy.ll @@ -1,3 +1,4 @@ +; NOTE: Assertions have been autogenerated by utils/update_test_checks.py ; RUN: opt < %s -instcombine -S | FileCheck %s declare void @llvm.memcpy.p0i8.p0i8.i32(i8* nocapture, i8* nocapture, i32, i1) nounwind @@ -17,7 +18,7 @@ define void @test1(i8* %a) { define void @test2(i8* %a) { ; CHECK-LABEL: @test2( -; CHECK-NEXT: tail call void @llvm.memcpy.p0i8.p0i8.i32(i8* %a, i8* %a, i32 100, i1 true) +; CHECK-NEXT: tail call void @llvm.memcpy.p0i8.p0i8.i32(i8* [[A:%.*]], i8* [[A]], i32 100, i1 true) ; CHECK-NEXT: ret void ; tail call void @llvm.memcpy.p0i8.p0i8.i32(i8* %a, i8* %a, i32 100, i1 true) @@ -28,10 +29,21 @@ define void @test2(i8* %a) { define void @test3(i8* %d, i8* %s) { ; CHECK-LABEL: @test3( -; CHECK-NEXT: tail call void @llvm.memcpy.p0i8.p0i8.i64(i8* align 4 %d, i8* align 4 %s, i64 17179869184, i1 false) +; CHECK-NEXT: tail call void @llvm.memcpy.p0i8.p0i8.i64(i8* align 4 [[D:%.*]], i8* align 4 [[S:%.*]], i64 17179869184, i1 false) ; CHECK-NEXT: ret void ; tail call void @llvm.memcpy.p0i8.p0i8.i64(i8* align 4 %d, i8* align 4 %s, i64 17179869184, i1 false) ret void } +@UnknownConstant = external constant i128 + +define void @memcpy_to_constant(i8* %src) { +; CHECK-LABEL: @memcpy_to_constant( +; CHECK-NEXT: call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 4 bitcast (i128* @UnknownConstant to i8*), i8* align 1 [[SRC:%.*]], i32 16, i1 false) +; CHECK-NEXT: ret void +; + %dest = bitcast i128* @UnknownConstant to i8* + call void @llvm.memcpy.p0i8.p0i8.i32(i8* %dest, i8* %src, i32 16, i1 false) + ret void +} diff --git a/test/Transforms/InstCombine/memmove.ll b/test/Transforms/InstCombine/memmove.ll index 18e0c634636..5c695959ccd 100644 --- a/test/Transforms/InstCombine/memmove.ll +++ b/test/Transforms/InstCombine/memmove.ll @@ -1,3 +1,4 @@ +; NOTE: Assertions have been autogenerated by utils/update_test_checks.py ; This test makes sure that memmove instructions are properly eliminated. ; ; RUN: opt < %s -instcombine -S | FileCheck %s @@ -8,30 +9,33 @@ @hello_u = constant [8 x i8] c"hello_u\00" ; <[8 x i8]*> [#uses=1] define void @test1(i8* %A, i8* %B, i32 %N) { - ;; CHECK-LABEL: test1 - ;; CHECK-NEXT: ret void +; CHECK-LABEL: @test1( +; CHECK-NEXT: ret void +; call void @llvm.memmove.p0i8.p0i8.i32(i8* %A, i8* %B, i32 0, i1 false) ret void } define void @test2(i8* %A, i32 %N) { ;; dest can't alias source since we can't write to source! - ;; CHECK-LABEL: test2 - ;; CHECK-NEXT: call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 1 %A, i8* align 16 getelementptr inbounds ([33 x i8], [33 x i8]* @S, i{{32|64}} 0, i{{32|64}} 0), i32 %N, i1 false) - ;; CHECK-NEXT: ret void +; CHECK-LABEL: @test2( +; CHECK-NEXT: call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 1 [[A:%.*]], i8* align 16 getelementptr inbounds ([33 x i8], [33 x i8]* @S, i64 0, i64 0), i32 [[N:%.*]], i1 false) +; CHECK-NEXT: ret void +; call void @llvm.memmove.p0i8.p0i8.i32(i8* %A, i8* getelementptr inbounds ([33 x i8], [33 x i8]* @S, i32 0, i32 0), i32 %N, i1 false) ret void } define i32 @test3([1024 x i8]* %target) { ; arg: [1024 x i8]*> [#uses=1] - ;; CHECK-LABEL: test3 - ;; CHECK-NEXT: [[P1:%[^\s]+]] = bitcast [1024 x i8]* %target to i16* - ;; CHECK-NEXT: store i16 104, i16* [[P1]], align 2 - ;; CHECK-NEXT: [[P2:%[^\s]+]] = bitcast [1024 x i8]* %target to i32* - ;; CHECK-NEXT: store i32 7103848, i32* [[P2]], align 4 - ;; CHECK-NEXT: [[P3:%[^\s]+]] = bitcast [1024 x i8]* %target to i64* - ;; CHECK-NEXT: store i64 33037504440198504, i64* [[P3]], align 8 - ;; CHECK-NEXT: ret i32 0 +; CHECK-LABEL: @test3( +; CHECK-NEXT: [[TMP1:%.*]] = bitcast [1024 x i8]* [[TARGET:%.*]] to i16* +; CHECK-NEXT: store i16 104, i16* [[TMP1]], align 2 +; CHECK-NEXT: [[TMP2:%.*]] = bitcast [1024 x i8]* [[TARGET]] to i32* +; CHECK-NEXT: store i32 7103848, i32* [[TMP2]], align 4 +; CHECK-NEXT: [[TMP3:%.*]] = bitcast [1024 x i8]* [[TARGET]] to i64* +; CHECK-NEXT: store i64 33037504440198504, i64* [[TMP3]], align 8 +; CHECK-NEXT: ret i32 0 +; %h_p = getelementptr [2 x i8], [2 x i8]* @h, i32 0, i32 0 ; [#uses=1] %hel_p = getelementptr [4 x i8], [4 x i8]* @hel, i32 0, i32 0 ; [#uses=1] %hello_u_p = getelementptr [8 x i8], [8 x i8]* @hello_u, i32 0, i32 0 ; [#uses=1] @@ -44,10 +48,24 @@ define i32 @test3([1024 x i8]* %target) { ; arg: [1024 x i8]*> [#uses=1] ; PR2370 define void @test4(i8* %a) { - ;; CHECK-LABEL: test4 - ;; CHECK-NEXT: ret void +; CHECK-LABEL: @test4( +; CHECK-NEXT: ret void +; tail call void @llvm.memmove.p0i8.p0i8.i32(i8* %a, i8* %a, i32 100, i1 false) ret void } +@UnknownConstant = external constant i128 + +define void @memmove_to_constant(i8* %src) { +; CHECK-LABEL: @memmove_to_constant( +; CHECK-NEXT: call void @llvm.memmove.p0i8.p0i8.i32(i8* align 4 bitcast (i128* @UnknownConstant to i8*), i8* align 1 [[SRC:%.*]], i32 16, i1 false) +; CHECK-NEXT: ret void +; + %dest = bitcast i128* @UnknownConstant to i8* + call void @llvm.memmove.p0i8.p0i8.i32(i8* %dest, i8* %src, i32 16, i1 false) + ret void +} + + declare void @llvm.memmove.p0i8.p0i8.i32(i8* nocapture, i8* nocapture readonly, i32, i1) argmemonly nounwind diff --git a/test/Transforms/InstCombine/memset.ll b/test/Transforms/InstCombine/memset.ll index a41d65cdf5d..1efb2e48a29 100644 --- a/test/Transforms/InstCombine/memset.ll +++ b/test/Transforms/InstCombine/memset.ll @@ -1,16 +1,18 @@ +; NOTE: Assertions have been autogenerated by utils/update_test_checks.py ; RUN: opt < %s -instcombine -S | FileCheck %s define i32 @test([1024 x i8]* %target) { - ;; CHECK-LABEL: test - ;; CHECK-NEXT: [[P1:%[^\s]+]] = getelementptr inbounds [1024 x i8], [1024 x i8]* %target, i64 0, i64 0 - ;; CHECK-NEXT: store i8 1, i8* [[P1]], align 1 - ;; CHECK-NEXT: [[P2:%[^\s]+]] = bitcast [1024 x i8]* %target to i16* - ;; CHECK-NEXT: store i16 257, i16* [[P2]], align 2 - ;; CHECK-NEXT: [[P3:%[^\s]+]] = bitcast [1024 x i8]* %target to i32* - ;; CHECK-NEXT: store i32 16843009, i32* [[P3]], align 4 - ;; CHECK-NEXT: [[P4:%[^\s]+]] = bitcast [1024 x i8]* %target to i64* - ;; CHECK-NEXT: store i64 72340172838076673, i64* [[P4]], align 8 - ;; CHECK-NEXT: ret i32 0 +; CHECK-LABEL: @test( +; CHECK-NEXT: [[TMP1:%.*]] = getelementptr inbounds [1024 x i8], [1024 x i8]* [[TARGET:%.*]], i64 0, i64 0 +; CHECK-NEXT: store i8 1, i8* [[TMP1]], align 1 +; CHECK-NEXT: [[TMP2:%.*]] = bitcast [1024 x i8]* [[TARGET]] to i16* +; CHECK-NEXT: store i16 257, i16* [[TMP2]], align 2 +; CHECK-NEXT: [[TMP3:%.*]] = bitcast [1024 x i8]* [[TARGET]] to i32* +; CHECK-NEXT: store i32 16843009, i32* [[TMP3]], align 4 +; CHECK-NEXT: [[TMP4:%.*]] = bitcast [1024 x i8]* [[TARGET]] to i64* +; CHECK-NEXT: store i64 72340172838076673, i64* [[TMP4]], align 8 +; CHECK-NEXT: ret i32 0 +; %target_p = getelementptr [1024 x i8], [1024 x i8]* %target, i32 0, i32 0 call void @llvm.memset.p0i8.i32(i8* %target_p, i8 1, i32 0, i1 false) call void @llvm.memset.p0i8.i32(i8* %target_p, i8 1, i32 1, i1 false) @@ -20,4 +22,16 @@ define i32 @test([1024 x i8]* %target) { ret i32 0 } +@Unknown = external constant i128 + +define void @memset_to_constant() { +; CHECK-LABEL: @memset_to_constant( +; CHECK-NEXT: call void @llvm.memset.p0i8.i32(i8* align 4 bitcast (i128* @Unknown to i8*), i8 0, i32 16, i1 false) +; CHECK-NEXT: ret void +; + %p = bitcast i128* @Unknown to i8* + call void @llvm.memset.p0i8.i32(i8* %p, i8 0, i32 16, i1 false) + ret void +} + declare void @llvm.memset.p0i8.i32(i8* nocapture writeonly, i8, i32, i1) argmemonly nounwind diff --git a/test/Transforms/InstCombine/store.ll b/test/Transforms/InstCombine/store.ll index 77b6a276f7c..c7c8374f10e 100644 --- a/test/Transforms/InstCombine/store.ll +++ b/test/Transforms/InstCombine/store.ll @@ -291,6 +291,17 @@ define void @write_back7(i32* %p) { ret void } +@Unknown = external constant i32 + +define void @store_to_constant() { +; CHECK-LABEL: @store_to_constant( +; CHECK-NEXT: store i32 0, i32* @Unknown, align 4 +; CHECK-NEXT: ret void +; + store i32 0, i32* @Unknown + ret void +} + !0 = !{!4, !4, i64 0} !1 = !{!"omnipotent char", !2} !2 = !{!"Simple C/C++ TBAA"}