From: Dmitri Gribenko <gribozavr@gmail.com>
Date: Thu, 23 Aug 2012 22:40:40 +0000 (+0000)
Subject: Attaching comments to decls: since it was decided that Decl::isImplicit should
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=7dd88609b6774152993bee8bed189aafc4c6f61a;p=clang

Attaching comments to decls: since it was decided that Decl::isImplicit should
not be set for implicit instantiations, remove the FIXME.  This should be the
last bit for PR13634.  The actual fix happened in r162238.

Motivation: it might be misleading to mark implicit instantiations as
Decl::isImplicit = true.  Because then, in order to be consistent, we should
mark all instantiated members as implicit.  But the user did actually type the
declaration for the member, but the compiler played with it a little bit.


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@162488 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/AST/ASTContext.cpp b/lib/AST/ASTContext.cpp
index 1144fcd0d9..d94ad42b3c 100644
--- a/lib/AST/ASTContext.cpp
+++ b/lib/AST/ASTContext.cpp
@@ -67,8 +67,6 @@ RawComment *ASTContext::getRawCommentForDeclNoCache(const Decl *D) const {
     return NULL;
 
   // User can not attach documentation to implicit instantiations.
-  // FIXME: all these implicit instantiations shoud be marked as implicit
-  // declarations and get caught by condition above.
   if (const FunctionDecl *FD = dyn_cast<FunctionDecl>(D)) {
     if (FD->getTemplateSpecializationKind() == TSK_ImplicitInstantiation)
       return NULL;