From: Antony Dovgal <tony2001@php.net>
Date: Wed, 6 Sep 2006 12:07:32 +0000 (+0000)
Subject: do not search for empty strings with strpos() and strrpos()
X-Git-Tag: php-5.2.0RC4~86
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=7d7f84562c8c2cf651354c9daeee0805ad0362e6;p=php

do not search for empty strings with strpos() and strrpos()
---

diff --git a/ext/iconv/iconv.c b/ext/iconv/iconv.c
index 0564b731ac..b86df00111 100644
--- a/ext/iconv/iconv.c
+++ b/ext/iconv/iconv.c
@@ -1946,6 +1946,10 @@ PHP_FUNCTION(iconv_strpos)
 		RETURN_FALSE;
 	}
 
+	if (ndl_len < 1) {
+		RETURN_FALSE;
+	}
+
 	err = _php_iconv_strpos(&retval, haystk, haystk_len, ndl, ndl_len,
 	                        offset, charset); 
 	_php_iconv_show_error(err, GENERIC_SUPERSET_NAME, charset TSRMLS_CC);
@@ -1981,6 +1985,10 @@ PHP_FUNCTION(iconv_strrpos)
 		RETURN_FALSE;
 	}
 
+	if (ndl_len < 1) {
+		RETURN_FALSE;
+	}
+
 	err = _php_iconv_strpos(&retval, haystk, haystk_len, ndl, ndl_len,
 	                        -1, charset); 
 	_php_iconv_show_error(err, GENERIC_SUPERSET_NAME, charset TSRMLS_CC);
diff --git a/ext/iconv/tests/iconv_strpos.phpt b/ext/iconv/tests/iconv_strpos.phpt
index ccf4ea74a7..6965f6fae1 100644
--- a/ext/iconv/tests/iconv_strpos.phpt
+++ b/ext/iconv/tests/iconv_strpos.phpt
@@ -31,6 +31,10 @@ foo(str_repeat("abcab", 60)."abcdb".str_repeat("adabc", 60), "abcd", 0);
 foo(str_repeat("¤¢¤¤¤¦¤¨¤ª", 30)."¤¤¤¦¤ª¤¨¤¢".str_repeat("¤¢¤¤¤¨¤ª¤¦", 30), "¤¦¤ª", 0, "EUC-JP");
 $str = str_repeat("¤¢¤¤¤¦¤¨¤ª", 60).'$'.str_repeat("¤¢¤¤¤¨¤ª¤¦", 60);
 foo($str, '$', 0, "ISO-2022-JP", "EUC-JP");
+
+var_dump(iconv_strpos("string", ""));
+var_dump(iconv_strpos("", "string"));
+
 ?>
 --EXPECTF--
 2: %s
@@ -50,3 +54,5 @@ int(302)
 int(151)
 int(1)
 int(300)
+bool(false)
+bool(false)
diff --git a/ext/iconv/tests/iconv_strrpos.phpt b/ext/iconv/tests/iconv_strrpos.phpt
index f150f88422..ee977f2c31 100644
--- a/ext/iconv/tests/iconv_strrpos.phpt
+++ b/ext/iconv/tests/iconv_strrpos.phpt
@@ -32,6 +32,10 @@ for ($i = 0; $i <=6; ++$i) {
 	$str = str_repeat("¤¢¤¤¤¦¤¨¤ª", 60).str_repeat('$', $i).str_repeat("¤¢¤¤¤¨¤ª¤¦", 60);
 	foo($str, '$', "ISO-2022-JP", "EUC-JP");
 }
+
+var_dump(iconv_strrpos("string", ""));
+var_dump(iconv_strrpos("", "string"));
+
 ?>
 --EXPECT--
 int(14)
@@ -54,3 +58,5 @@ int(605)
 int(304)
 int(606)
 int(305)
+bool(false)
+bool(false)