From: Antoine Pitrou <solipsis@pitrou.net>
Date: Sun, 19 Sep 2010 23:28:30 +0000 (+0000)
Subject: Make error more explicit in test_finalize_with_trace
X-Git-Tag: v3.2a3~207
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=7c08744f523e0c054156ea06eb97d09a8caae314;p=python

Make error more explicit in test_finalize_with_trace
---

diff --git a/Lib/test/test_threading.py b/Lib/test/test_threading.py
index 39c5a17231..19ba730143 100644
--- a/Lib/test/test_threading.py
+++ b/Lib/test/test_threading.py
@@ -304,7 +304,7 @@ class ThreadTests(BaseTestCase):
         # Issue1733757
         # Avoid a deadlock when sys.settrace steps into threading._shutdown
         import subprocess
-        rc = subprocess.call([sys.executable, "-c", """if 1:
+        p = subprocess.Popen([sys.executable, "-c", """if 1:
             import sys, threading
 
             # A deadlock-killer, to prevent the
@@ -324,9 +324,14 @@ class ThreadTests(BaseTestCase):
                 return func
 
             sys.settrace(func)
-            """])
+            """],
+            stdout=subprocess.PIPE,
+            stderr=subprocess.PIPE)
+        stdout, stderr = p.communicate()
+        rc = p.returncode
         self.assertFalse(rc == 2, "interpreted was blocked")
-        self.assertTrue(rc == 0, "Unexpected error")
+        self.assertTrue(rc == 0,
+                        "Unexpected error: " + ascii(stderr))
 
     def test_join_nondaemon_on_shutdown(self):
         # Issue 1722344