From: Peter Wu <peter@lekensteyn.nl>
Date: Thu, 6 Nov 2014 00:32:42 +0000 (+0100)
Subject: tests: fix libhostname visibility
X-Git-Tag: curl-7_40_0~388
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=7bdfdd09e4ed32eb1ec690087b29a2a4c3a066ca;p=curl

tests: fix libhostname visibility

I noticed that a patched cmake build would pass tests with a fake local
hostname, but the autotools build skips them:

    got unexpected host name back, LD_PRELOAD failed

It turns out that -fvisibility=hidden hides the symbol, and since the
tests are not part of libcurl, it fails too. Just remove the LIBCURL
guard.

Broken since cURL 7.30 (commit 83a42ee20ea7fc25abb61c0b7ef56ebe712d7093,
"curl.h: stricter CURL_EXTERN linkage decorations logic").

Signed-off-by: Peter Wu <peter@lekensteyn.nl>
---

diff --git a/tests/libtest/sethostname.h b/tests/libtest/sethostname.h
index 192f037ab..032eaa078 100644
--- a/tests/libtest/sethostname.h
+++ b/tests/libtest/sethostname.h
@@ -23,12 +23,8 @@
 #ifdef CURL_STATICLIB
 #  define LIBHOSTNAME_EXTERN
 #elif defined(WIN32) || defined(__SYMBIAN32__)
-#  if defined(BUILDING_LIBCURL)
-#    define LIBHOSTNAME_EXTERN  __declspec(dllexport)
-#  else
-#    define LIBHOSTNAME_EXTERN  __declspec(dllimport)
-#  endif
-#elif defined(BUILDING_LIBCURL) && defined(CURL_HIDDEN_SYMBOLS)
+#  define LIBHOSTNAME_EXTERN  __declspec(dllexport)
+#elif defined(CURL_HIDDEN_SYMBOLS)
 #  define LIBHOSTNAME_EXTERN CURL_EXTERN_SYMBOL
 #else
 #  define LIBHOSTNAME_EXTERN