From: Andy Polyakov <appro@openssl.org>
Date: Tue, 24 Jul 2018 13:48:15 +0000 (+0200)
Subject: ec/ecp_nistz256.c: fix Coverity nit.
X-Git-Tag: OpenSSL_1_1_1-pre9~94
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=7b953da40d0dee56f360902f872dc8989f6a3e1f;p=openssl

ec/ecp_nistz256.c: fix Coverity nit.

|ctx| recently became unconditionally non-NULL and is already dereferenced
earlier.

Reviewed-by: Rich Salz <rsalz@openssl.org>
---

diff --git a/crypto/ec/ecp_nistz256.c b/crypto/ec/ecp_nistz256.c
index 54c9ed2808..b0564bdbd0 100644
--- a/crypto/ec/ecp_nistz256.c
+++ b/crypto/ec/ecp_nistz256.c
@@ -1339,8 +1339,7 @@ __owur static int ecp_nistz256_points_mul(const EC_GROUP *group,
     ret = 1;
 
 err:
-    if (ctx)
-        BN_CTX_end(ctx);
+    BN_CTX_end(ctx);
     OPENSSL_free(new_points);
     OPENSSL_free(new_scalars);
     return ret;