From: Niels Provos <provos@gmail.com>
Date: Sun, 16 Sep 2007 02:26:37 +0000 (+0000)
Subject: optimize by removing a variable
X-Git-Tag: release-2.0.1-alpha~569
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=7b7742fce7b694977579b9f2e11bc974b1c346da;p=libevent

optimize by removing a variable

svn:r433
---

diff --git a/event_tagging.c b/event_tagging.c
index 955b3a0c..ddc281e1 100644
--- a/event_tagging.c
+++ b/event_tagging.c
@@ -155,26 +155,25 @@ decode_int_internal(uint32_t *pnumber, struct evbuffer *evbuf, int dodrain)
 	uint32_t number = 0;
 	uint8_t *data = EVBUFFER_DATA(evbuf);
 	int len = EVBUFFER_LENGTH(evbuf);
-	int nibbles = 0, off;
+	int nibbles = 0;
 
 	if (!len)
 		return (-1);
 
 	nibbles = ((data[0] & 0xf0) >> 4) + 1;
-	if (nibbles > 8 || (nibbles >> 1) > len - 1)
+	if (nibbles > 8 || (nibbles >> 1) + 1 > len)
 		return (-1);
+	len = (nibbles >> 1) + 1;
 
-	off = nibbles;
-	while (off > 0) {
+	while (nibbles > 0) {
 		number <<= 4;
-		if (off & 0x1)
-			number |= data[off >> 1] & 0x0f;
+		if (nibbles & 0x1)
+			number |= data[nibbles >> 1] & 0x0f;
 		else
-			number |= (data[off >> 1] & 0xf0) >> 4;
-		off--;
+			number |= (data[nibbles >> 1] & 0xf0) >> 4;
+		nibbles--;
 	}
 
-	len = (nibbles >> 1) + 1;
 	if (dodrain)
 		evbuffer_drain(evbuf, len);