From: Dmitry Stogov <dmitry@zend.com>
Date: Wed, 21 Jun 2017 09:57:24 +0000 (+0300)
Subject: Avoid useless duplication
X-Git-Tag: php-7.2.0alpha3~64
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=7af5741333925928d83b3921c4f50aebd472c01f;p=php

Avoid useless duplication
---

diff --git a/main/php_variables.c b/main/php_variables.c
index ae5e922ef6..1052e16edf 100644
--- a/main/php_variables.c
+++ b/main/php_variables.c
@@ -458,7 +458,7 @@ SAPI_API SAPI_TREAT_DATA_FUNC(php_default_treat_data)
 	switch (arg) {
 		case PARSE_GET:
 		case PARSE_STRING:
-			separator = (char *) estrdup(PG(arg_separator).input);
+			separator = PG(arg_separator).input;
 			break;
 		case PARSE_COOKIE:
 			separator = ";\0";
@@ -513,10 +513,6 @@ next_cookie:
 		var = php_strtok_r(NULL, separator, &strtok_buf);
 	}
 
-	if (arg != PARSE_COOKIE) {
-		efree(separator);
-	}
-
 	if (free_buffer) {
 		efree(res);
 	}