From: Joseph Tate Date: Thu, 7 Mar 2002 23:52:57 +0000 (+0000) Subject: Commented out a few lines that were causing a segfault in the unlink code. X-Git-Tag: help~141 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=7ad4b465ca671c14056638ca1b001c41e59ae5ff;p=php Commented out a few lines that were causing a segfault in the unlink code. This fixes bug #14522. I've tested that it does not cause a segfault under RH 7.2, and retains all functionality. I recommend that this patch be considered for the PHP_4_2_0 tree as well, as having a function that core dumps every time is a bad thing(TM). --- diff --git a/ext/domxml/php_domxml.c b/ext/domxml/php_domxml.c index b138bec173..2774755ec3 100644 --- a/ext/domxml/php_domxml.c +++ b/ext/domxml/php_domxml.c @@ -1802,8 +1802,12 @@ PHP_FUNCTION(domxml_node_unlink_node) DOMXML_PARAM_NONE(nodep, id, le_domxmlnodep); xmlUnlinkNode(nodep); - xmlFreeNode(nodep); - zval_dtor(id); /* This is not enough because the children won't be deleted */ + /* This causes a Segmentation Fault for some reason. Removing + it allows the user to re-add the node at some other time, in + addition to fixing the segfault. Node will be freed at + shutdown. */ + /*xmlFreeNode(nodep); + zval_dtor(id);*/ /* This is not enough because the children won't be deleted */ } /* }}} */