From: Xinchen Hui Date: Mon, 5 Jan 2015 05:26:10 +0000 (-0500) Subject: Revert "Fix memory leak when dereferencing reference with refcount 1" X-Git-Tag: PRE_PHP7_REMOVALS~31^2~25 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=7aab9659ee9c8bc15490d16b4064d64a3846147c;p=php Revert "Fix memory leak when dereferencing reference with refcount 1" This reverts commit f4cb5cc09d44e6940fecebe52b8013b288ed67c4. breaks tests Zend/tests/bug27268.phpt and Zend/tests/bug68262.phpt --- diff --git a/Zend/zend_variables.c b/Zend/zend_variables.c index b476bd9f8d..56b9b67598 100644 --- a/Zend/zend_variables.c +++ b/Zend/zend_variables.c @@ -205,9 +205,7 @@ ZEND_API void zval_add_ref(zval *p) { if (Z_REFCOUNTED_P(p)) { if (Z_ISREF_P(p) && Z_REFCOUNT_P(p) == 1) { - zend_reference *ref = Z_REF_P(p); ZVAL_COPY(p, Z_REFVAL_P(p)); - efree(ref); } else { Z_ADDREF_P(p); }