From: Azat Khuzhin <azat@libevent.org>
Date: Sun, 31 Mar 2019 23:37:41 +0000 (+0300)
Subject: evrpc: do not check req twice
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=7a8cc11406db7f3ea70425b71e31ece0b07e9e08;p=libevent

evrpc: do not check req twice

reported by µchex:
  "In evrpc.c, pointer req is dereferenced on line 881 before it is null
checked on line 894."
---

diff --git a/evrpc.c b/evrpc.c
index 3b5260fc..46bf3f7e 100644
--- a/evrpc.c
+++ b/evrpc.c
@@ -892,8 +892,7 @@ evrpc_reply_done(struct evhttp_request *req, void *arg)
 			 * layer is going to free it.  we need to
 			 * request ownership explicitly
 			 */
-			if (req != NULL)
-				evhttp_request_own(req);
+			evhttp_request_own(req);
 
 			evrpc_pause_request(pool, ctx,
 			    evrpc_reply_done_closure);