From: Jordan Lee <jordan@transmissionbt.com>
Date: Sat, 19 Feb 2011 12:30:18 +0000 (+0000)
Subject: (trunk libT) closeBadPeers() part 2 of 2: this function was serving two purposes... 
X-Git-Tag: 2.30b1~273
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=7a8ab0ddbee9331cfa44d1c77e3e98dab8da579a;p=transmission

(trunk libT) closeBadPeers() part 2 of 2: this function was serving two purposes, which wasn't clear from its name. refactor slightly to make the purpose and name match.
---

diff --git a/libtransmission/peer-mgr.c b/libtransmission/peer-mgr.c
index 19e7c668b..c44065fed 100644
--- a/libtransmission/peer-mgr.c
+++ b/libtransmission/peer-mgr.c
@@ -3270,22 +3270,12 @@ removeAllPeers( Torrent * t )
 static void
 closeBadPeers( Torrent * t, const time_t now_sec )
 {
-    if( !t->isRunning )
-    {
-        removeAllPeers( t );
-    }
-    else
-    {
-        int i;
-        int mustCloseCount;
-        struct tr_peer ** mustClose;
-
-        /* disconnect the really bad peers */
-        mustClose = getPeersToClose( t, TR_MUST_CLOSE, now_sec, &mustCloseCount );
-        for( i=0; i<mustCloseCount; ++i )
-            closePeer( t, mustClose[i] );
-        tr_free( mustClose );
-    }
+    int i;
+    int mustCloseCount;
+    struct tr_peer ** mustClose = getPeersToClose( t, TR_MUST_CLOSE, now_sec, &mustCloseCount );
+    for( i=0; i<mustCloseCount; ++i )
+        closePeer( t, mustClose[i] );
+    tr_free( mustClose );
 }
 
 struct peer_liveliness
@@ -3454,7 +3444,10 @@ reconnectPulse( int foo UNUSED, short bar UNUSED, void * vmgr )
     /* remove crappy peers */
     tor = NULL;
     while(( tor = tr_torrentNext( mgr->session, tor )))
-        closeBadPeers( tor->torrentPeers, now_sec );
+        if( !tor->torrentPeers->isRunning )
+            removeAllPeers( tor->torrentPeers );
+        else
+            closeBadPeers( tor->torrentPeers, now_sec );
 
     /* try to make new peer connections */
     makeNewPeerConnections( mgr, MAX_CONNECTIONS_PER_PULSE );