From: Bram Moolenaar <Bram@vim.org>
Date: Mon, 19 Feb 2018 22:10:02 +0000 (+0100)
Subject: patch 8.0.1525: using :wqa exits even if a job runs in a terminal window
X-Git-Tag: v8.0.1525
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=7a76092a51fc5446426a4bfd9eb6503ec61bf9e9;p=vim

patch 8.0.1525: using :wqa exits even if a job runs in a terminal window

Problem:    Using :wqa exits even if a job runs in a terminal window. (Jason
            Felice)
Solution:   Check if a terminal has a running job. (closes #2654)
---

diff --git a/src/buffer.c b/src/buffer.c
index c3e0c5080..a3a7e00c4 100644
--- a/src/buffer.c
+++ b/src/buffer.c
@@ -1875,10 +1875,10 @@ no_write_message(void)
 }
 
     void
-no_write_message_nobang(void)
+no_write_message_nobang(buf_T *buf UNUSED)
 {
 #ifdef FEAT_TERMINAL
-    if (term_job_running(curbuf->b_term))
+    if (term_job_running(buf->b_term))
 	EMSG(_("E948: Job still running"));
     else
 #endif
diff --git a/src/ex_cmds.c b/src/ex_cmds.c
index a4d6221b0..e05215a59 100644
--- a/src/ex_cmds.c
+++ b/src/ex_cmds.c
@@ -3428,6 +3428,14 @@ do_wqall(exarg_T *eap)
 
     FOR_ALL_BUFFERS(buf)
     {
+#ifdef FEAT_TERMINAL
+	if (exiting && term_job_running(buf->b_term))
+	{
+	    no_write_message_nobang(buf);
+	    ++error;
+	}
+	else
+#endif
 	if (bufIsChanged(buf) && !bt_dontwrite(buf))
 	{
 	    /*
diff --git a/src/ex_cmds2.c b/src/ex_cmds2.c
index 6476d5516..805e8c458 100644
--- a/src/ex_cmds2.c
+++ b/src/ex_cmds2.c
@@ -2110,7 +2110,7 @@ check_changed(buf_T *buf, int flags)
 	if (flags & CCGD_EXCMD)
 	    no_write_message();
 	else
-	    no_write_message_nobang();
+	    no_write_message_nobang(curbuf);
 	return TRUE;
     }
     return FALSE;
diff --git a/src/proto/buffer.pro b/src/proto/buffer.pro
index 485eb027d..8b9884354 100644
--- a/src/proto/buffer.pro
+++ b/src/proto/buffer.pro
@@ -14,7 +14,7 @@ void set_curbuf(buf_T *buf, int action);
 void enter_buffer(buf_T *buf);
 void do_autochdir(void);
 void no_write_message(void);
-void no_write_message_nobang(void);
+void no_write_message_nobang(buf_T *buf);
 buf_T *buflist_new(char_u *ffname, char_u *sfname, linenr_T lnum, int flags);
 void free_buf_options(buf_T *buf, int free_p_ff);
 int buflist_getfile(int n, linenr_T lnum, int options, int forceit);
diff --git a/src/testdir/test_terminal.vim b/src/testdir/test_terminal.vim
index 0c2e289c1..ac54bbc1e 100644
--- a/src/testdir/test_terminal.vim
+++ b/src/testdir/test_terminal.vim
@@ -712,6 +712,15 @@ func Test_terminal_wall()
   unlet g:job
 endfunc
 
+func Test_terminal_wqall()
+  let buf = Run_shell_in_terminal({})
+  call assert_fails('wqall', 'E948')
+  call Stop_shell_in_terminal(buf)
+  call term_wait(buf)
+  exe buf . 'bwipe'
+  unlet g:job
+endfunc
+
 func Test_terminal_composing_unicode()
   let save_enc = &encoding
   set encoding=utf-8
diff --git a/src/version.c b/src/version.c
index 78b8431d1..3bed185ec 100644
--- a/src/version.c
+++ b/src/version.c
@@ -771,6 +771,8 @@ static char *(features[]) =
 
 static int included_patches[] =
 {   /* Add new patch number below this line */
+/**/
+    1525,
 /**/
     1524,
 /**/