From: Tim Peters <tim.peters@gmail.com>
Date: Thu, 12 Aug 2004 18:37:10 +0000 (+0000)
Subject: Boosted the stack reservation for python.exe and python_w.exe from the
X-Git-Tag: v2.4a3~271
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=79b52b7261fb80392c660d296b71b4c44acf2565;p=python

Boosted the stack reservation for python.exe and python_w.exe from the
default 1MB to 2 million bytes.  The test suite passes with -uall again
(test_compiler no longer drives WinXP into an insane state).
---

diff --git a/Misc/NEWS b/Misc/NEWS
index 632d446289..c4a1cf1773 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -75,6 +75,16 @@ Tests
 Windows
 -------
 
+- Boosted the stack reservation for python.exe and pythonw.exe from
+  the default 1MB to 2MB.  Stack frames under VC 7.1 for 2.4 are enough
+  bigger than under VC 6.0 for 2.3.4 that deeply recursive progams
+  within the default sys.getrecursionlimit() default value of 1000 were
+  able to suffer undetected C stack overflows.  The standard test program
+  test_compiler was one such program.  If a Python process on Windows
+  "just vanishes" without a trace, and without an error message of any
+  kind, but with an exit code of 128, undetected stack overflow may be
+  the problem.
+
 Mac
 ---
 
diff --git a/PCbuild/python.vcproj b/PCbuild/python.vcproj
index 0c3c4b6b42..722bf4344c 100644
--- a/PCbuild/python.vcproj
+++ b/PCbuild/python.vcproj
@@ -47,6 +47,7 @@
 				GenerateDebugInformation="TRUE"
 				ProgramDatabaseFile=".\./python.pdb"
 				SubSystem="1"
+				StackReserveSize="2000000"
 				BaseAddress="0x1d000000"
 				TargetMachine="1"/>
 			<Tool
@@ -109,6 +110,7 @@
 				GenerateDebugInformation="TRUE"
 				ProgramDatabaseFile=".\./python_d.pdb"
 				SubSystem="1"
+				StackReserveSize="2000000"
 				BaseAddress="0x1d000000"
 				TargetMachine="1"/>
 			<Tool
@@ -179,6 +181,7 @@
 				GenerateDebugInformation="TRUE"
 				ProgramDatabaseFile=".\./python.pdb"
 				SubSystem="1"
+				StackReserveSize="2000000"
 				BaseAddress="0x1d000000"
 				TargetMachine="0"/>
 			<Tool
diff --git a/PCbuild/pythonw.vcproj b/PCbuild/pythonw.vcproj
index 0eab69062d..1ac107a15a 100644
--- a/PCbuild/pythonw.vcproj
+++ b/PCbuild/pythonw.vcproj
@@ -42,6 +42,7 @@
 				GenerateDebugInformation="TRUE"
 				ProgramDatabaseFile=".\./pythonw_d.pdb"
 				SubSystem="2"
+				StackReserveSize="2000000"
 				BaseAddress="0x1d000000"
 				TargetMachine="1"/>
 			<Tool
@@ -108,6 +109,7 @@
 				GenerateDebugInformation="TRUE"
 				ProgramDatabaseFile=".\./pythonw.pdb"
 				SubSystem="2"
+				StackReserveSize="2000000"
 				BaseAddress="0x1d000000"
 				TargetMachine="1"/>
 			<Tool
@@ -179,6 +181,7 @@
 				GenerateDebugInformation="TRUE"
 				ProgramDatabaseFile=".\./pythonw.pdb"
 				SubSystem="2"
+				StackReserveSize="2000000"
 				BaseAddress="0x1d000000"
 				TargetMachine="0"/>
 			<Tool