From: Dr. Stephen Henson <steve@openssl.org>
Date: Wed, 12 May 2004 18:20:57 +0000 (+0000)
Subject: Make self signing option of 'x509' use random serial numbers too.
X-Git-Tag: OpenSSL_0_9_7e~109
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=7922ba2feb01e416ba8d49918d7394fcedd211dc;p=openssl

Make self signing option of 'x509' use random serial numbers too.
---

diff --git a/apps/x509.c b/apps/x509.c
index 5f5542a829..dedd9f1a9a 100644
--- a/apps/x509.c
+++ b/apps/x509.c
@@ -593,12 +593,16 @@ bad:
 		if ((x=X509_new()) == NULL) goto end;
 		ci=x->cert_info;
 
-		if (sno)
+		if (sno == NULL)
 			{
-			if (!X509_set_serialNumber(x, sno))
+			sno = ASN1_INTEGER_new();
+			if (!sno || !rand_serial(NULL, sno))
 				goto end;
 			}
-		else if (!ASN1_INTEGER_set(X509_get_serialNumber(x),0)) goto end;
+
+		if (!X509_set_serialNumber(x, sno)) 
+			goto end;
+
 		if (!X509_set_issuer_name(x,req->req_info->subject)) goto end;
 		if (!X509_set_subject_name(x,req->req_info->subject)) goto end;