From: Sanjay Patel <spatel@rotateright.com>
Date: Tue, 7 May 2019 22:58:31 +0000 (+0000)
Subject: [ValueTracking] add logic for known-never-nan with minnum/maxnum
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=79040e11a599e9c40d76f7a853aa21f34873d452;p=llvm

[ValueTracking] add logic for known-never-nan with minnum/maxnum

From the LangRef: "Returns NaN only if both operands are NaN."

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@360206 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/Analysis/ValueTracking.cpp b/lib/Analysis/ValueTracking.cpp
index 7c16b21c928..54575441b71 100644
--- a/lib/Analysis/ValueTracking.cpp
+++ b/lib/Analysis/ValueTracking.cpp
@@ -3136,6 +3136,11 @@ bool llvm::isKnownNeverNaN(const Value *V, const TargetLibraryInfo *TLI,
     case Intrinsic::sqrt:
       return isKnownNeverNaN(II->getArgOperand(0), TLI, Depth + 1) &&
              CannotBeOrderedLessThanZero(II->getArgOperand(0), TLI);
+    case Intrinsic::minnum:
+    case Intrinsic::maxnum:
+      // If either operand is not NaN, the result is not NaN.
+      return isKnownNeverNaN(II->getArgOperand(0), TLI, Depth + 1) ||
+             isKnownNeverNaN(II->getArgOperand(1), TLI, Depth + 1);
     default:
       return false;
     }
diff --git a/test/Transforms/InstSimplify/floating-point-compare.ll b/test/Transforms/InstSimplify/floating-point-compare.ll
index a2785fab84d..1a1afbe9133 100644
--- a/test/Transforms/InstSimplify/floating-point-compare.ll
+++ b/test/Transforms/InstSimplify/floating-point-compare.ll
@@ -487,9 +487,7 @@ define i1 @orderedLessZeroMaximum(float, float) {
 
 define i1 @minnum_non_nan(float %x) {
 ; CHECK-LABEL: @minnum_non_nan(
-; CHECK-NEXT:    [[MIN:%.*]] = call float @llvm.minnum.f32(float 5.000000e-01, float [[X:%.*]])
-; CHECK-NEXT:    [[CMP:%.*]] = fcmp ord float [[MIN]], 1.000000e+00
-; CHECK-NEXT:    ret i1 [[CMP]]
+; CHECK-NEXT:    ret i1 true
 ;
   %min = call float @llvm.minnum.f32(float 0.5, float %x)
   %cmp = fcmp ord float %min, 1.0
@@ -498,9 +496,7 @@ define i1 @minnum_non_nan(float %x) {
 
 define i1 @maxnum_non_nan(float %x) {
 ; CHECK-LABEL: @maxnum_non_nan(
-; CHECK-NEXT:    [[MIN:%.*]] = call float @llvm.maxnum.f32(float [[X:%.*]], float 4.200000e+01)
-; CHECK-NEXT:    [[CMP:%.*]] = fcmp uno float [[MIN]], 1.200000e+01
-; CHECK-NEXT:    ret i1 [[CMP]]
+; CHECK-NEXT:    ret i1 false
 ;
   %min = call float @llvm.maxnum.f32(float %x, float 42.0)
   %cmp = fcmp uno float %min, 12.0