From: Michael Ow <mow@svn.icu-project.org>
Date: Wed, 3 Aug 2011 20:09:44 +0000 (+0000)
Subject: ICU-8452 Fix some Cygwin GCC and MinGW build errors
X-Git-Tag: milestone-59-0-1~4600
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=78937c5834b74cffd841e684bee113d29e4e6fd9;p=icu

ICU-8452 Fix some Cygwin GCC and MinGW build errors

X-SVN-Rev: 30457
---

diff --git a/icu4c/source/common/putilimp.h b/icu4c/source/common/putilimp.h
index 4d92acd35a2..40cb6cf3e5b 100644
--- a/icu4c/source/common/putilimp.h
+++ b/icu4c/source/common/putilimp.h
@@ -103,7 +103,7 @@ typedef size_t uintptr_t;
 
 #ifdef U_HAVE_POPEN
     /* Use the predefined value. */
-#elif U_PLATFORM_HAS_WIN32_API
+#elif U_PLATFORM == U_PF_WINDOWS
 #   define U_HAVE_POPEN 0
 #else
 #   define U_HAVE_POPEN 1
diff --git a/icu4c/source/common/unicode/platform.h b/icu4c/source/common/unicode/platform.h
index 2d2c6dace17..5fab7ba6a1a 100644
--- a/icu4c/source/common/unicode/platform.h
+++ b/icu4c/source/common/unicode/platform.h
@@ -185,7 +185,11 @@
 #ifdef U_PLATFORM_HAS_WIN32_API
     /* Use the predefined value. */
 #elif U_PF_WINDOWS <= U_PLATFORM && U_PLATFORM <= U_PF_CYGWIN
-#   define U_PLATFORM_HAS_WIN32_API 1
+#   if U_PLATFORM == U_PF_CYGWIN && defined(__GNUC__)
+#       define U_PLATFORM_HAS_WIN32_API 0
+#   else
+#       define U_PLATFORM_HAS_WIN32_API 1
+#   endif
 #else
 #   define U_PLATFORM_HAS_WIN32_API 0
 #endif
@@ -504,7 +508,7 @@
      * Newer Mac OS X has size 4.
      */
 #   define U_SIZEOF_WCHAR_T 1
-#elif U_PLATFORM_HAS_WIN32_API
+#elif U_PLATFORM_HAS_WIN32_API || U_PLATFORM == U_PF_CYGWIN
 #   define U_SIZEOF_WCHAR_T 2
 #elif U_PLATFORM == U_PF_AIX
     /*
diff --git a/icu4c/source/tools/pkgdata/pkgdata.cpp b/icu4c/source/tools/pkgdata/pkgdata.cpp
index a7125717d6f..f237fe44322 100644
--- a/icu4c/source/tools/pkgdata/pkgdata.cpp
+++ b/icu4c/source/tools/pkgdata/pkgdata.cpp
@@ -20,14 +20,16 @@
 
 #include "unicode/utypes.h"
 
+#include "unicode/putil.h"
+#include "putilimp.h"
+
 #if U_HAVE_POPEN
-#if (U_PF_MINGW <= U_PLATFORM && U_PLATFORM <= U_PF_CYGWIN) && defined(__STRICT_ANSI__)
+#if (U_PF_MINGW <= U_PLATFORM || U_PLATFORM <= U_PF_CYGWIN) && defined(__STRICT_ANSI__)
 /* popen/pclose aren't defined in strict ANSI on Cygwin and MinGW */
 #undef __STRICT_ANSI__
 #endif
 #endif
 
-#include "unicode/putil.h"
 #include "cmemory.h"
 #include "cstring.h"
 #include "filestrm.h"
@@ -35,7 +37,6 @@
 #include "unicode/uclean.h"
 #include "unewdata.h"
 #include "uoptions.h"
-#include "putilimp.h"
 #include "package.h"
 #include "pkg_icu.h"
 #include "pkg_genc.h"