From: Michael Paquier <michael@paquier.xyz>
Date: Wed, 24 Jul 2019 22:55:43 +0000 (+0900)
Subject: Fix failure with pgperlcritic from the TAP test of synchronous replication
X-Git-Tag: REL9_6_15~19
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=781568ede6062400acadde6a6b0056ada1c8a4c1;p=postgresql

Fix failure with pgperlcritic from the TAP test of synchronous replication

Oversight in 7d81bdc, which introduced a new routine in perl lacking a
return clause.  Per buildfarm member crake.

Backpatch down to 9.6 like its parent.

Reported-by: Andrew Dunstan
Discussion: https://postgr.es/m/16da29fa-d504-1380-7095-40de586dc038@2ndQuadrant.com
Backpatch-through: 9.6
---

diff --git a/src/test/recovery/t/007_sync_rep.pl b/src/test/recovery/t/007_sync_rep.pl
index c88430fb27..5d9bd504e4 100644
--- a/src/test/recovery/t/007_sync_rep.pl
+++ b/src/test/recovery/t/007_sync_rep.pl
@@ -58,6 +58,7 @@ sub start_standby_and_wait
 
 	print("### Waiting for standby \"$standby_name\" on \"$master_name\"\n");
 	$master->poll_query_until('postgres', $query);
+	return;
 }
 
 # Initialize master node