From: James Zern <jzern@google.com>
Date: Sun, 30 Jul 2017 19:48:28 +0000 (-0700)
Subject: highbd_inv_txfm_sse4: make << of neg. val a multiply
X-Git-Tag: v1.7.0~276^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=78155b7ed5a2fe7d2447912e3f0b1dc7463c650a;p=libvpx

highbd_inv_txfm_sse4: make << of neg. val a multiply

left shifting a negative value is undefined; quiets a ubsan warning.
this is applied to a constant, no change in the generated code.

Change-Id: I595f0ff7904ef025e07bb80234293d958dc9f254
---

diff --git a/vpx_dsp/x86/highbd_inv_txfm_sse4.h b/vpx_dsp/x86/highbd_inv_txfm_sse4.h
index 170f641d3..d19887d00 100644
--- a/vpx_dsp/x86/highbd_inv_txfm_sse4.h
+++ b/vpx_dsp/x86/highbd_inv_txfm_sse4.h
@@ -18,7 +18,7 @@
 
 static INLINE __m128i multiplication_round_shift_sse4_1(
     const __m128i *const in /*in[2]*/, const int c) {
-  const __m128i pair_c = pair_set_epi32(c << 2, 0);
+  const __m128i pair_c = pair_set_epi32(c * 4, 0);
   __m128i t0, t1;
 
   t0 = _mm_mul_epi32(in[0], pair_c);