From: sr55 Date: Fri, 28 Sep 2018 20:59:37 +0000 (+0100) Subject: WinGui: Improving Accessibility of the new Queue (and fixed a few other issues around... X-Git-Tag: 1.2.0~130 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=77fa0c755330a25202203b3d4ad0974d141ce1cb;p=handbrake WinGui: Improving Accessibility of the new Queue (and fixed a few other issues around the UI in this area too) --- diff --git a/win/CS/HandBrakeWPF/Properties/ResourcesUI.Designer.cs b/win/CS/HandBrakeWPF/Properties/ResourcesUI.Designer.cs index 43a64912a..e889002fc 100644 --- a/win/CS/HandBrakeWPF/Properties/ResourcesUI.Designer.cs +++ b/win/CS/HandBrakeWPF/Properties/ResourcesUI.Designer.cs @@ -456,6 +456,24 @@ namespace HandBrakeWPF.Properties { } } + /// + /// Looks up a localized string similar to Preset:. + /// + public static string FiltersView_DeinterlacePreset { + get { + return ResourceManager.GetString("FiltersView_DeinterlacePreset", resourceCulture); + } + } + + /// + /// Looks up a localized string similar to Deinterlace Preset. + /// + public static string FiltersView_DeinterlacePresetAuto { + get { + return ResourceManager.GetString("FiltersView_DeinterlacePresetAuto", resourceCulture); + } + } + /// /// Looks up a localized string similar to Denoise:. /// @@ -465,6 +483,24 @@ namespace HandBrakeWPF.Properties { } } + /// + /// Looks up a localized string similar to Denoise Preset. + /// + public static string FiltersView_DenoisePresetAuto { + get { + return ResourceManager.GetString("FiltersView_DenoisePresetAuto", resourceCulture); + } + } + + /// + /// Looks up a localized string similar to Denoise Tune. + /// + public static string FiltersView_DenoiseTuneAuto { + get { + return ResourceManager.GetString("FiltersView_DenoiseTuneAuto", resourceCulture); + } + } + /// /// Looks up a localized string similar to Detelecine:. /// @@ -501,6 +537,15 @@ namespace HandBrakeWPF.Properties { } } + /// + /// Looks up a localized string similar to Interlace Detection:. + /// + public static string FiltersView_InterlaceDetection { + get { + return ResourceManager.GetString("FiltersView_InterlaceDetection", resourceCulture); + } + } + /// /// Looks up a localized string similar to Preset:. /// @@ -528,6 +573,24 @@ namespace HandBrakeWPF.Properties { } } + /// + /// Looks up a localized string similar to Sharpen Preset. + /// + public static string FiltersView_SharpenPresetAuto { + get { + return ResourceManager.GetString("FiltersView_SharpenPresetAuto", resourceCulture); + } + } + + /// + /// Looks up a localized string similar to Sharpen Tune. + /// + public static string FiltersView_SharpenTuneAuto { + get { + return ResourceManager.GetString("FiltersView_SharpenTuneAuto", resourceCulture); + } + } + /// /// Looks up a localized string similar to Tune:. /// @@ -798,6 +861,15 @@ namespace HandBrakeWPF.Properties { } } + /// + /// Looks up a localized string similar to Format:. + /// + public static string MainView_Format { + get { + return ResourceManager.GetString("MainView_Format", resourceCulture); + } + } + /// /// Looks up a localized string similar to Help. /// @@ -2105,6 +2177,15 @@ namespace HandBrakeWPF.Properties { } } + /// + /// Looks up a localized string similar to Delete. + /// + public static string QueueView_Delete { + get { + return ResourceManager.GetString("QueueView_Delete", resourceCulture); + } + } + /// /// Looks up a localized string similar to Destination: . /// @@ -2132,6 +2213,15 @@ namespace HandBrakeWPF.Properties { } } + /// + /// Looks up a localized string similar to Edit. + /// + public static string QueueView_Edit { + get { + return ResourceManager.GetString("QueueView_Edit", resourceCulture); + } + } + /// /// Looks up a localized string similar to End Time:. /// @@ -2285,6 +2375,15 @@ namespace HandBrakeWPF.Properties { } } + /// + /// Looks up a localized string similar to Retry. + /// + public static string QueueView_Retry { + get { + return ResourceManager.GetString("QueueView_Retry", resourceCulture); + } + } + /// /// Looks up a localized string similar to Shutdown. /// @@ -2601,7 +2700,16 @@ namespace HandBrakeWPF.Properties { } /// - /// Looks up a localized string similar to Use system default player. + /// Looks up a localized string similar to Select a preview image. + /// + public static string StaticPreviewView_SelectPreviewImage { + get { + return ResourceManager.GetString("StaticPreviewView_SelectPreviewImage", resourceCulture); + } + } + + /// + /// Looks up a localized string similar to Use system default video player. /// public static string StaticPreviewView_UseSystemDefault { get { @@ -2871,7 +2979,7 @@ namespace HandBrakeWPF.Properties { } /// - /// Looks up a localized string similar to Encoder Level. + /// Looks up a localized string similar to Encoder Level:. /// public static string VideoView_EncoderLevel { get { diff --git a/win/CS/HandBrakeWPF/Properties/ResourcesUI.resx b/win/CS/HandBrakeWPF/Properties/ResourcesUI.resx index 914d9525e..8dda5a635 100644 --- a/win/CS/HandBrakeWPF/Properties/ResourcesUI.resx +++ b/win/CS/HandBrakeWPF/Properties/ResourcesUI.resx @@ -556,7 +556,7 @@ Live Preview - Use system default player + Use system default video player Add Closed Captions when available @@ -595,7 +595,7 @@ Constant Quality: - Encoder Level + Encoder Level: Encoder Preset: @@ -1097,4 +1097,40 @@ This will not affect your current settings in the Subtitle tab. Retry Failed + + Preset: + + + Deinterlace Preset + + + Denoise Preset + + + Denoise Tune + + + Interlace Detection: + + + Sharpen Preset + + + Sharpen Tune + + + Format: + + + Delete + + + Edit + + + Retry + + + Select a preview image + \ No newline at end of file diff --git a/win/CS/HandBrakeWPF/Services/Encode/Model/Models/AudioTrack.cs b/win/CS/HandBrakeWPF/Services/Encode/Model/Models/AudioTrack.cs index 96a531f34..393b5efc2 100644 --- a/win/CS/HandBrakeWPF/Services/Encode/Model/Models/AudioTrack.cs +++ b/win/CS/HandBrakeWPF/Services/Encode/Model/Models/AudioTrack.cs @@ -705,5 +705,10 @@ namespace HandBrakeWPF.Services.Encode.Model.Models } #endregion + + public override string ToString() + { + return string.Format("Audio Track: Title {0}", this.ScannedTrack.ToString()); + } } } \ No newline at end of file diff --git a/win/CS/HandBrakeWPF/Services/Encode/Model/Models/SubtitleTrack.cs b/win/CS/HandBrakeWPF/Services/Encode/Model/Models/SubtitleTrack.cs index 9b195152b..3eef3bc4f 100644 --- a/win/CS/HandBrakeWPF/Services/Encode/Model/Models/SubtitleTrack.cs +++ b/win/CS/HandBrakeWPF/Services/Encode/Model/Models/SubtitleTrack.cs @@ -304,5 +304,10 @@ namespace HandBrakeWPF.Services.Encode.Model.Models return this.SrtFileName != "-" && this.SrtFileName != null; } } + + public override string ToString() + { + return string.Format("Subtitle Track: Title {0}", this.SrtFileName ?? this.SourceTrack.ToString()); + } } } \ No newline at end of file diff --git a/win/CS/HandBrakeWPF/Services/Queue/Model/QueueTask.cs b/win/CS/HandBrakeWPF/Services/Queue/Model/QueueTask.cs index d8456519a..77c9b66ad 100644 --- a/win/CS/HandBrakeWPF/Services/Queue/Model/QueueTask.cs +++ b/win/CS/HandBrakeWPF/Services/Queue/Model/QueueTask.cs @@ -9,6 +9,8 @@ namespace HandBrakeWPF.Services.Queue.Model { + using System.Runtime.CompilerServices; + using Caliburn.Micro; using HandBrake.Interop.Model; @@ -138,5 +140,10 @@ namespace HandBrakeWPF.Services.Queue.Model { return this.Id.GetHashCode(); } + + public override string ToString() + { + return string.Format("Encode Task. Title: {0}, Source: {1}, Destination: {2}", this.Task.Title, this.Task.Source, this.Task.Destination); + } } } \ No newline at end of file diff --git a/win/CS/HandBrakeWPF/Views/FiltersView.xaml b/win/CS/HandBrakeWPF/Views/FiltersView.xaml index 7c323869f..5ad267656 100644 --- a/win/CS/HandBrakeWPF/Views/FiltersView.xaml +++ b/win/CS/HandBrakeWPF/Views/FiltersView.xaml @@ -54,16 +54,16 @@ + HorizontalAlignment="Left" AutomationProperties.Name="{x:Static Properties:ResourcesUI.FiltersView_Detelecine}" /> - + + VerticalContentAlignment="Center" AutomationProperties.Name="{x:Static Properties:ResourcesUI.FiltersView_InterlaceDetection}"/> @@ -75,13 +75,15 @@ + SelectedItem="{Binding SelectedDeinterlaceFilter, Converter={StaticResource boolComboConverter}}" ToolTip="{x:Static Properties:ResourcesTooltips.FilterView_Deinterlace}" + AutomationProperties.Name="{x:Static Properties:ResourcesUI.FiltersView_Deinterlace}" /> - + + SelectedItem="{Binding SelectedDeInterlacePreset}" DisplayMemberPath="Name" Visibility="{Binding IsDeinterlaceEnabled, Converter={StaticResource boolToVisConverter}}" + AutomationProperties.Name="{x:Static Properties:ResourcesUI.FiltersView_DeinterlacePresetAuto}" /> + HorizontalAlignment="Left" VerticalAlignment="Center" Margin="0,0,0,10" ToolTip="{x:Static Properties:ResourcesTooltips.FilterView_Denoise}" + AutomationProperties.Name="{x:Static Properties:ResourcesUI.FiltersView_Denoise}"/> @@ -111,6 +115,7 @@ @@ -126,6 +131,7 @@ + MinWidth="100" HorizontalAlignment="Center" VerticalAlignment="Center" DisplayMemberPath="DisplayName" + AutomationProperties.Name="{x:Static Properties:ResourcesUI.FiltersView_SharpenPresetAuto}" > @@ -144,7 +151,8 @@ - + @@ -165,7 +173,8 @@ + HorizontalAlignment="Left" ToolTip="{x:Static Properties:ResourcesTooltips.FilterView_Deblock}" + AutomationProperties.Name="{x:Static Properties:ResourcesUI.FiltersView_Deblock}" /> - - - - - + @@ -146,29 +147,6 @@ Header="{x:Static Properties:ResourcesUI.QueueView_QuitHandBrake}"/> - - - @@ -380,13 +358,13 @@ - - - - - diff --git a/win/CS/HandBrakeWPF/Views/StaticPreviewView.xaml b/win/CS/HandBrakeWPF/Views/StaticPreviewView.xaml index 2ec3dcaa3..d17798a4b 100644 --- a/win/CS/HandBrakeWPF/Views/StaticPreviewView.xaml +++ b/win/CS/HandBrakeWPF/Views/StaticPreviewView.xaml @@ -31,7 +31,7 @@ - - + + SelectedItem="{Binding SelectedOutputFormat, Converter={StaticResource enumComboConverter}}" + AutomationProperties.Name="{x:Static Properties:ResourcesUI.MainView_Format}" /> - + @@ -62,7 +62,8 @@ - + + ToolTip="{x:Static Properties:ResourcesTooltips.Video_AvgBitrate}" AutomationProperties.Name="{x:Static Properties:ResourcesUI.VideoView_AverageBitrate}" /> @@ -162,7 +163,7 @@ - @@ -174,16 +175,19 @@ + Style="{StaticResource LongToolTipHolder}" ToolTip="{x:Static Properties:ResourcesTooltips.Video_Profile}" + AutomationProperties.Name="{x:Static Properties:ResourcesUI.VideoView_EncoderProfile}" /> + Style="{StaticResource LongToolTipHolder}" ToolTip="{x:Static Properties:ResourcesTooltips.Video_Level}" + AutomationProperties.Name="{x:Static Properties:ResourcesUI.VideoView_EncoderLevel}" />