From: Magnus Jacobsson Date: Tue, 14 Sep 2021 18:06:19 +0000 (+0200) Subject: cmd/edgepaint: MSBuild: define GVDLL in the project file X-Git-Tag: 2.49.2~32^2~6 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=77f615e211b252d11e19cbdc4f063036654b2528;p=graphviz cmd/edgepaint: MSBuild: define GVDLL in the project file Without this change, an upcoming commit in this series that unites the storage class attributes in lib/common/globals.h that have diverged for different build systems, would cause edgepaint to generate a segmentation fault (error code 3221225477 = 0xC0000005: access violation) when started on native Windows. Also towards https://gitlab.com/graphviz/graphviz/-/issues/2058#note_678679545. --- diff --git a/cmd/edgepaint/edgepaint.vcxproj b/cmd/edgepaint/edgepaint.vcxproj index d00e18771..a27c69483 100644 --- a/cmd/edgepaint/edgepaint.vcxproj +++ b/cmd/edgepaint/edgepaint.vcxproj @@ -53,7 +53,7 @@ Disabled $(SolutionDir)windows\include;$(SolutionDir)windows\dependencies\libraries\vcpkg\installed\x86-windows\include;$(SolutionDir)lib;$(SolutionDir)lib\cdt;$(SolutionDir)lib\cgraph;$(SolutionDir)lib\common;%(AdditionalIncludeDirectories) - _DEBUG;_LIB;%(PreprocessorDefinitions) + _DEBUG;_LIB;GVDLL;%(PreprocessorDefinitions) true EnableFastChecks MultiThreadedDebugDLL @@ -79,7 +79,7 @@ MaxSpeed true $(SolutionDir)windows\include;$(SolutionDir)windows\dependencies\libraries\vcpkg\installed\x86-windows\include;$(SolutionDir)lib;$(SolutionDir)lib\cdt;$(SolutionDir)lib\cgraph;$(SolutionDir)lib\common;%(AdditionalIncludeDirectories) - NDEBUG;_LIB;%(PreprocessorDefinitions) + NDEBUG;_LIB;GVDLL;%(PreprocessorDefinitions) true Level4