From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date: Fri, 7 Jun 2019 09:42:27 +0000 (+0300)
Subject: Fix copy-pasto in freeing memory on error in vacuumlo.
X-Git-Tag: REL_12_BETA2~58
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=77b68e3a4f854d95350a3366ecfc8b3b506ebaa7;p=postgresql

Fix copy-pasto in freeing memory on error in vacuumlo.

It's harmless to call PQfreemem() with a NULL argument, so the only
consequence was that if allocating 'schema' failed, but allocating 'table'
or 'field' succeeded, we would leak a bit of memory. That's highly
unlikely to happen, so this is just academical, but let's get it right.

Per bug #15838 from Timur Birsh. Backpatch back to 9.5, where the
PQfreemem() calls were introduced.

Discussion: https://www.postgresql.org/message-id/15838-3221652c72c5e69d@postgresql.org
---

diff --git a/contrib/vacuumlo/vacuumlo.c b/contrib/vacuumlo/vacuumlo.c
index ac3ff60e81..73c06a043e 100644
--- a/contrib/vacuumlo/vacuumlo.c
+++ b/contrib/vacuumlo/vacuumlo.c
@@ -243,9 +243,9 @@ vacuumlo(const char *database, const struct _param *param)
 			PQfinish(conn);
 			if (schema != NULL)
 				PQfreemem(schema);
-			if (schema != NULL)
+			if (table != NULL)
 				PQfreemem(table);
-			if (schema != NULL)
+			if (field != NULL)
 				PQfreemem(field);
 			return -1;
 		}