From: Brian Behlendorf <behlendorf1@llnl.gov>
Date: Wed, 14 Mar 2012 19:36:49 +0000 (-0700)
Subject: Add missing NULL in zpl_xattr_handlers
X-Git-Tag: zfs-0.6.0-rc7~1
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=77a405ae52e4a902f7cc3790e2a73d044c66d962;p=zfs

Add missing NULL in zpl_xattr_handlers

The xattr_resolve_name() helper function expects the registered
list of xattr handlers to be NULL terminated.  This NULL was
accidentally missing which could result in a NULL dereference.

Interestingly this issue only manifested itself on certain 32-bit
systems.  Presumably on 64-bit kernels we just always happen to
get lucky and the memory following the structure is zeroed.

Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Issue #594
---

diff --git a/module/zfs/zpl_xattr.c b/module/zfs/zpl_xattr.c
index dbe61df98..c03764fc5 100644
--- a/module/zfs/zpl_xattr.c
+++ b/module/zfs/zpl_xattr.c
@@ -674,4 +674,5 @@ xattr_handler_t *zpl_xattr_handlers[] = {
 	&zpl_xattr_acl_access_handler,
 	&zpl_xattr_acl_default_handler,
 #endif /* HAVE_POSIX_ACLS */
+	NULL
 };