From: Mitch Hagstrand <mhagstrand@gmail.com>
Date: Sun, 9 Apr 2017 22:30:35 +0000 (-0700)
Subject: Fix of Bug #74383: Wrong reflection on Phar::running
X-Git-Tag: php-7.1.5RC1~59^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=775afd5e2de8091ddbb91373ce23ad2d6a8b3fac;p=php

Fix of Bug #74383: Wrong reflection on Phar::running
---

diff --git a/NEWS b/NEWS
index 049cf66209..0e3d3b1fd7 100644
--- a/NEWS
+++ b/NEWS
@@ -18,6 +18,9 @@ PHP                                                                        NEWS
   . Fixed bug #74341 (openssl_x509_parse fails to parse ASN.1 UTCTime without
     seconds). (Moritz Fain)
 
+- phar:
+  . Fixed reflection on Phar::isRunning parameters. (mhagstrand)
+
 13 Apr 2017 PHP 7.0.18
 
 - Core:
diff --git a/ext/phar/phar_object.c b/ext/phar/phar_object.c
index 31d443cd43..1799268297 100644
--- a/ext/phar/phar_object.c
+++ b/ext/phar/phar_object.c
@@ -5191,7 +5191,7 @@ ZEND_BEGIN_ARG_INFO_EX(arginfo_phar_webPhar, 0, 0, 0)
 ZEND_END_ARG_INFO()
 
 PHAR_ARG_INFO
-ZEND_BEGIN_ARG_INFO_EX(arginfo_phar_running, 0, 0, 1)
+ZEND_BEGIN_ARG_INFO_EX(arginfo_phar_running, 0, 0, 0)
 	ZEND_ARG_INFO(0, retphar)
 ZEND_END_ARG_INFO()
 
diff --git a/ext/phar/tests/bug74383.phpt b/ext/phar/tests/bug74383.phpt
new file mode 100644
index 0000000000..366c4fcb9b
--- /dev/null
+++ b/ext/phar/tests/bug74383.phpt
@@ -0,0 +1,20 @@
+--TEST--
+Phar: bug #74383: Wrong reflection on Phar::running
+--SKIPIF--
+<?php if (!extension_loaded("phar") || !extension_loaded('reflection')) die("skip"); ?>
+--FILE--
+<?php
+$rc = new ReflectionClass(Phar::class);
+$rm = $rc->getMethod("running");
+echo $rm->getNumberOfParameters();
+echo PHP_EOL;
+echo $rm->getNumberOfRequiredParameters();
+echo PHP_EOL;
+echo (int) $rm->getParameters()[0]->isOptional();
+
+?>
+
+--EXPECT--
+1
+0
+1
\ No newline at end of file