From: Ted Kremenek <kremenek@apple.com>
Date: Thu, 15 May 2008 21:49:04 +0000 (+0000)
Subject: Removed bogus "return true" in Expr::isConstantExpr that returned true for all
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=774e4af13a0b7683563a22c6b99e4dda45334cc8;p=clang

Removed bogus "return true" in Expr::isConstantExpr that returned true for all
expressions. This appears to be a regression introduced in r51113 that caused
many test cases to fail (there is still a test case in the Analysis directory
that is failing):

http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20080512/005706.html


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@51164 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/AST/Expr.cpp b/lib/AST/Expr.cpp
index 45c6a8721f..962819b733 100644
--- a/lib/AST/Expr.cpp
+++ b/lib/AST/Expr.cpp
@@ -500,7 +500,6 @@ Expr *Expr::IgnoreParenCasts() {
 
 
 bool Expr::isConstantExpr(ASTContext &Ctx, SourceLocation *Loc) const {
-  return true;
   switch (getStmtClass()) {
   default:
     if (Loc) *Loc = getLocStart();