From: Mark Hansen Date: Fri, 22 May 2020 01:52:36 +0000 (+1000) Subject: Skip test_large_graphs on win32. X-Git-Tag: 2.44.1~69^2~1 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=76b8d02c793ac23dc167a085b44fa9dbbce24f84;p=graphviz Skip test_large_graphs on win32. This test is expected to fail on win32 due to Window's smaller stack size defaults: - Windows by default uses 1MB stacks: https://docs.microsoft.com/en-us/windows/win32/procthread/thread-stack-size - Linux x86_64 seems to usually have a default of 8MB (architecture dependent): ``` mark@x86_64_linux $ ulimit -a | grep stack Maximum stack size (kB, -s) 8192 mark@arm32v6 $ ulimit -a | grep stack Maximum stack size (kB, -s) 8192 ``` This test failure is not a regression (it would have been failing before 81c3a3af), and it's blocking other submissions. This change gets the CI green again to unblock forward progress. --- diff --git a/tests/regression_tests/large/test_large_graphs.py b/tests/regression_tests/large/test_large_graphs.py index 7294d89cc..5a94fbb95 100644 --- a/tests/regression_tests/large/test_large_graphs.py +++ b/tests/regression_tests/large/test_large_graphs.py @@ -1,13 +1,15 @@ -from unittest import TestCase +from unittest import TestCase, skipIf import subprocess import os +import sys TEST_DIR = os.path.dirname(os.path.realpath(__file__)) class TestLargeGraphs(TestCase): + @skipIf(sys.platform == 'win32', reason='https://gitlab.com/graphviz/graphviz/-/issues/1710') def test_long_chain(self): """ This test will fail on 32bit Windows machine if compiled with stack size < 16MB.