From: Ilia Alshanetsky Date: Sun, 23 Oct 2005 15:29:09 +0000 (+0000) Subject: Fixed memory leak on error. X-Git-Tag: php-5.1.0RC4~45 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=76ad7425adca8138d8302ceecee346ffbd326ede;p=php Fixed memory leak on error. --- diff --git a/ext/standard/dns.c b/ext/standard/dns.c index 8d1d1d0df0..b7445bf40e 100644 --- a/ext/standard/dns.c +++ b/ext/standard/dns.c @@ -350,7 +350,7 @@ PHP_MINIT_FUNCTION(dns) { #endif /* QFIXEDSZ */ #ifndef MAXHOSTNAMELEN -#define MAXHOSTNAMELEN 256 +#define MAXHOSTNAMELEN 1024 #endif /* MAXHOSTNAMELEN */ #ifndef MAXRESOURCERECORDS @@ -747,12 +747,14 @@ PHP_FUNCTION(dns_get_record) if (n<0) { php_error_docref(NULL TSRMLS_CC, E_WARNING, "res_nmkquery() failed"); zval_dtor(return_value); + res_nclose(&res); RETURN_FALSE; } n = res_nsend(&res, buf.qb2, n, answer.qb2, sizeof answer); if (n<0) { php_error_docref(NULL TSRMLS_CC, E_WARNING, "res_nsend() failed"); zval_dtor(return_value); + res_nclose(&res); RETURN_FALSE; } @@ -770,6 +772,7 @@ PHP_FUNCTION(dns_get_record) if (n < 0) { php_error_docref(NULL TSRMLS_CC, E_WARNING, "Unable to parse DNS data received"); zval_dtor(return_value); + res_nclose(&res); RETURN_FALSE; } cp += n + QFIXEDSZ;