From: Antoine Pitrou <solipsis@pitrou.net>
Date: Fri, 13 Feb 2009 13:52:33 +0000 (+0000)
Subject: Issue #5186: Reduce hash collisions for objects with no __hash__ method by
X-Git-Tag: v2.7a1~2034
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=76a4b896c4b976d2d17df0aa7cf5c982986f8771;p=python

Issue #5186: Reduce hash collisions for objects with no __hash__ method by
rotating the object pointer by 4 bits to the right.
---

diff --git a/Misc/NEWS b/Misc/NEWS
index 70a15d779a..b620a5a9f4 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -12,6 +12,9 @@ What's New in Python 2.7 alpha 1
 Core and Builtins
 -----------------
 
+- Issue #5186: Reduce hash collisions for objects with no __hash__ method by
+  rotating the object pointer by 4 bits to the right.
+
 - Issue #4575: Fix Py_IS_INFINITY macro to work correctly on x87 FPUs:
   it now forces its argument to double before testing for infinity.
 
diff --git a/Objects/object.c b/Objects/object.c
index 9108fd431a..8006fdab4d 100644
--- a/Objects/object.c
+++ b/Objects/object.c
@@ -1072,23 +1072,15 @@ _Py_HashDouble(double v)
 long
 _Py_HashPointer(void *p)
 {
-#if SIZEOF_LONG >= SIZEOF_VOID_P
-	return (long)p;
-#else
-	/* convert to a Python long and hash that */
-	PyObject* longobj;
 	long x;
-
-	if ((longobj = PyLong_FromVoidPtr(p)) == NULL) {
-		x = -1;
-		goto finally;
-	}
-	x = PyObject_Hash(longobj);
-
-finally:
-	Py_XDECREF(longobj);
+	size_t y = (size_t)p;
+	/* bottom 3 or 4 bits are likely to be 0; rotate y by 4 to avoid
+	   excessive hash collisions for dicts and sets */
+	y = (y >> 4) | (y << 8*SIZEOF_VOID_P - 4);
+	x = (long)y;
+	if (x == -1)
+		x = -2;
 	return x;
-#endif
 }
 
 long