From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Sun, 12 Mar 2017 20:01:33 +0000 (-0400)
Subject: Add "break"s to make it clearer what will happen in a nested switch.
X-Git-Tag: REL_10_BETA1~677
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=766f7fd613adbceaf1b40803793e10dc487f8596;p=postgresql

Add "break"s to make it clearer what will happen in a nested switch.

This could only matter if the guessed_type variable had a value that wasn't
a member of the PasswordType enum; but just in case, let's be sure that
control falls out to reach the elog(ERROR) at the end of the function.
Per gripe from Coverity.
---

diff --git a/src/backend/libpq/crypt.c b/src/backend/libpq/crypt.c
index bd3e936d38..9f0ae15b00 100644
--- a/src/backend/libpq/crypt.c
+++ b/src/backend/libpq/crypt.c
@@ -162,6 +162,7 @@ encrypt_password(PasswordType target_type, const char *role,
 				case PASSWORD_TYPE_MD5:
 					return pstrdup(password);
 			}
+			break;
 
 		case PASSWORD_TYPE_SCRAM:
 			switch (guessed_type)
@@ -178,6 +179,7 @@ encrypt_password(PasswordType target_type, const char *role,
 				case PASSWORD_TYPE_SCRAM:
 					return pstrdup(password);
 			}
+			break;
 	}
 
 	/*