From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 29 May 2013 21:20:16 +0000 (-0700)
Subject: Merge branch 'fc/transport-helper-error-reporting'
X-Git-Tag: v1.8.4-rc0~257
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=766f0f8ef755eeb7a79b87af9bc348a1ba824589;p=git

Merge branch 'fc/transport-helper-error-reporting'

Update transport helper to report errors and maintain ref hierarchy
used to keep track of remote helper state better.

* fc/transport-helper-error-reporting:
  transport-helper: fix remote helper namespace regression
  test: remote-helper: add missing and
  t5801: "VAR=VAL shell_func args" is forbidden
  transport-helper: update remote helper namespace
  transport-helper: trivial code shuffle
  transport-helper: warn when refspec is not used
  transport-helper: clarify pushing without refspecs
  transport-helper: update refspec documentation
  transport-helper: clarify *:* refspec
  transport-helper: improve push messages
  transport-helper: mention helper name when it dies
  transport-helper: report errors properly
---

766f0f8ef755eeb7a79b87af9bc348a1ba824589
diff --cc t/t5801-remote-helpers.sh
index dbb02e2afd,443e228ec5..16faa23154
--- a/t/t5801-remote-helpers.sh
+++ b/t/t5801-remote-helpers.sh
@@@ -167,25 -155,52 +156,71 @@@ test_expect_success 'push ref with exis
  	compare_refs local dup server dup
  '
  
 +test_expect_success GPG 'push signed tag' '
 +	(cd local &&
 +	git checkout master &&
 +	git tag -s -m signed-tag signed-tag &&
 +	git push origin signed-tag
 +	) &&
 +	compare_refs local signed-tag^{} server signed-tag^{} &&
 +	test_must_fail compare_refs local signed-tag server signed-tag
 +'
 +
 +test_expect_success GPG 'push signed tag with signed-tags capability' '
 +	(cd local &&
 +	git checkout master &&
 +	git tag -s -m signed-tag signed-tag-2 &&
 +	GIT_REMOTE_TESTGIT_SIGNED_TAGS=1 git push origin signed-tag-2
 +	) &&
 +	compare_refs local signed-tag-2 server signed-tag-2
 +'
 +
+ test_expect_success 'push update refs' '
+ 	(cd local &&
+ 	git checkout -b update master &&
+ 	echo update >>file &&
+ 	git commit -a -m update &&
+ 	git push origin update &&
+ 	git rev-parse --verify remotes/origin/update >expect &&
+ 	git rev-parse --verify testgit/origin/heads/update >actual &&
+ 	test_cmp expect actual
+ 	)
+ '
+ 
+ test_expect_success 'push update refs failure' '
+ 	(cd local &&
+ 	git checkout update &&
+ 	echo "update fail" >>file &&
+ 	git commit -a -m "update fail" &&
+ 	git rev-parse --verify testgit/origin/heads/update >expect &&
+ 	GIT_REMOTE_TESTGIT_PUSH_ERROR="non-fast forward" &&
+ 	export GIT_REMOTE_TESTGIT_PUSH_ERROR &&
+ 	test_expect_code 1 git push origin update &&
+ 	git rev-parse --verify testgit/origin/heads/update >actual &&
+ 	test_cmp expect actual
+ 	)
+ '
+ 
+ test_expect_success 'proper failure checks for fetching' '
+ 	(GIT_REMOTE_TESTGIT_FAILURE=1 &&
+ 	export GIT_REMOTE_TESTGIT_FAILURE &&
+ 	cd local &&
+ 	test_must_fail git fetch 2> error &&
+ 	cat error &&
+ 	grep -q "Error while running fast-import" error
+ 	)
+ '
+ 
+ test_expect_success 'proper failure checks for pushing' '
+ 	(GIT_REMOTE_TESTGIT_FAILURE=1 &&
+ 	export GIT_REMOTE_TESTGIT_FAILURE &&
+ 	cd local &&
+ 	test_must_fail git push --all 2> error &&
+ 	cat error &&
+ 	grep -q "Reading from helper .git-remote-testgit. failed" error
+ 	)
+ '
+ 
  test_expect_success 'push messages' '
  	(cd local &&
  	git checkout -b new_branch master &&
diff --cc transport-helper.c
index 522d79178e,6cd0be90e0..2f5ac3fbee
--- a/transport-helper.c
+++ b/transport-helper.c
@@@ -214,9 -212,12 +215,11 @@@ static struct child_process *get_helper
  		int i;
  		data->refspec_nr = refspec_nr;
  		data->refspecs = parse_fetch_refspec(refspec_nr, refspecs);
 -		for (i = 0; i < refspec_nr; i++) {
 +		for (i = 0; i < refspec_nr; i++)
  			free((char *)refspecs[i]);
 -		}
  		free(refspecs);
+ 	} else if (data->import || data->bidi_import || data->export) {
+ 		warning("This remote helper should implement refspec capability.");
  	}
  	strbuf_release(&buf);
  	if (debug)