From: Steve Holme <steve_holme@hotmail.com>
Date: Thu, 1 Jan 2015 04:56:16 +0000 (+0000)
Subject: smb.c: Fixed compilation warnings
X-Git-Tag: curl-7_40_0~42
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=7635577ad7321d59eb4bb17b5e4d80dbca459bfc;p=curl

smb.c: Fixed compilation warnings

smb.c:780: warning: passing 'char *' to parameter of type 'unsigned
           char *' converts between pointers to integer types with
           different sign
smb.c:781: warning: passing 'char *' to parameter of type 'unsigned
           char *' converts between pointers to integer types with
           different sign
smb.c:804: warning: passing 'char *' to parameter of type 'unsigned
           char *' converts between pointers to integer types with
           different sign
---

diff --git a/lib/smb.c b/lib/smb.c
index 028695932..3fbbf0ea5 100644
--- a/lib/smb.c
+++ b/lib/smb.c
@@ -6,6 +6,7 @@
  *                             \___|\___/|_| \_\_____|
  *
  * Copyright (C) 2014, Bill Nagel <wnagel@tycoint.com>, Exacq Technologies
+ * Copyright (C) 2015, Daniel Stenberg, <daniel@haxx.se>, et al.
  *
  * This software is licensed as described in the file COPYING, which
  * you should have received as part of this distribution. The terms
@@ -777,8 +778,10 @@ static CURLcode smb_request_state(struct connectdata *conn, bool *done)
       next_state = SMB_CLOSE;
       break;
     }
-    len = Curl_read16_le(((char *) msg) + sizeof(struct smb_header) + 11);
-    off = Curl_read16_le(((char *) msg) + sizeof(struct smb_header) + 13);
+    len = Curl_read16_le(((unsigned char *) msg) +
+                         sizeof(struct smb_header) + 11);
+    off = Curl_read16_le(((unsigned char *) msg) +
+                         sizeof(struct smb_header) + 13);
     if(len > 0) {
       result = Curl_client_write(conn, CLIENTWRITE_BODY,
                                  (char *)msg + off + sizeof(unsigned int),
@@ -801,7 +804,8 @@ static CURLcode smb_request_state(struct connectdata *conn, bool *done)
       next_state = SMB_CLOSE;
       break;
     }
-    len = Curl_read16_le(((char *) msg) + sizeof(struct smb_header) + 5);
+    len = Curl_read16_le(((unsigned char *) msg) +
+                         sizeof(struct smb_header) + 5);
     conn->data->req.bytecount += len;
     conn->data->req.offset += len;
     Curl_pgrsSetUploadCounter(conn->data, conn->data->req.bytecount);