From: Ilia Alshanetsky <iliaa@php.net>
Date: Wed, 21 Jul 2004 00:14:50 +0000 (+0000)
Subject: MFH: Abort earlier on invalid format.
X-Git-Tag: php-5.0.1RC1~94
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=7623887079494527e77fc56e8fc01a91ff1798d0;p=php

MFH: Abort earlier on invalid format.
---

diff --git a/ext/standard/sunfuncs.c b/ext/standard/sunfuncs.c
index 2eea641f4d..7413c2cd69 100644
--- a/ext/standard/sunfuncs.c
+++ b/ext/standard/sunfuncs.c
@@ -192,7 +192,10 @@ static void php_do_date_sunrise_sunset(INTERNAL_FUNCTION_PARAMETERS, int calc_su
 			}
 		case 5:
 			gmt_offset = php_idate('Z', time, 0) / 3600;
+			break;
 		default:
+			php_error_docref(NULL TSRMLS_CC, E_WARNING, "invalid format");
+			RETURN_FALSE;
 			break;
 	}
 	
@@ -210,9 +213,6 @@ static void php_do_date_sunrise_sunset(INTERNAL_FUNCTION_PARAMETERS, int calc_su
 		case SUNFUNCS_RET_DOUBLE:
 			RETURN_DOUBLE(ret);
 			break;
-		default:
-			php_error_docref(NULL TSRMLS_CC, E_WARNING, "invalid format");
-			RETURN_FALSE;
 	}
 }
 /* }}} */