From: Raymond Hettinger <python@rcn.com>
Date: Mon, 16 Jun 2008 01:49:18 +0000 (+0000)
Subject: Issue #3116 and #1792: Fix quadratic behavior in marshal.dumps().
X-Git-Tag: v2.5.3c1~87
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=75ee9eb9c60cc85925d2bfe9f92f2b2da81ddefd;p=python

Issue #3116 and #1792: Fix quadratic behavior in marshal.dumps().
---

diff --git a/Misc/NEWS b/Misc/NEWS
index 6363f80630..cdc3f9c748 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -48,6 +48,8 @@ Core and builtins
 Library
 -------
 
+- Issue #3116 and #1792:  Fix quadratic behavior in marshal.dumps().
+
 - Issue #2682: ctypes callback functions no longer contain a cyclic
   reference to themselves.
 
diff --git a/Python/marshal.c b/Python/marshal.c
index 897c15ec8a..c305bbe47c 100644
--- a/Python/marshal.c
+++ b/Python/marshal.c
@@ -65,7 +65,10 @@ w_more(int c, WFILE *p)
 	if (p->str == NULL)
 		return; /* An error already occurred */
 	size = PyString_Size(p->str);
-	newsize = size + 1024;
+	newsize = size + size + 1024;
+	if (newsize > 32*1024*1024) {
+		newsize = size + (size >> 3);	/* 12.5% overallocation */
+	}
 	if (_PyString_Resize(&p->str, newsize) != 0) {
 		p->ptr = p->end = NULL;
 	}