From: R David Murray <rdmurray@bitdance.com>
Date: Sun, 22 Mar 2015 16:33:46 +0000 (-0400)
Subject: #23700: fix/improve comment
X-Git-Tag: v3.5.0a3~40^2~16
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=75ed90a4cf07cd9236b4ed52d1c7cf09810a1749;p=python

#23700: fix/improve comment
---

diff --git a/Lib/tempfile.py b/Lib/tempfile.py
index cb18ae65f6..5eafc1fe7a 100644
--- a/Lib/tempfile.py
+++ b/Lib/tempfile.py
@@ -427,8 +427,10 @@ class _TemporaryFileWrapper:
     # iter() doesn't use __getattr__ to find the __iter__ method
     def __iter__(self):
         # Don't return iter(self.file), but yield from it to avoid closing
-        # file as long as it's being used as iterator, see issue #23000.
-        # XXX Also don't use "yield from"!
+        # file as long as it's being used as iterator (see issue #23700).  We
+        # can't use 'yield from' here because iter(file) returns the file
+        # object itself, which has a close method, and thus the file would get
+        # closed when the generator is finalized, due to PEP380 semantics.
         for line in self.file:
             yield line