From: Kevin McCarthy <kevin@8t8.us>
Date: Thu, 20 Dec 2018 02:36:19 +0000 (-0800)
Subject: More postpone cleanup.
X-Git-Tag: mutt-1-12-rel~173
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=755a72f74fab16e36f31f0f4e155c718d9b6b1a5;p=mutt

More postpone cleanup.

Provide an error message if $postponed is not set.

Make sure the clear content is freed for encrypted messages.

If the write_fcc() fails, make sure to restore the clear content.
---

diff --git a/send.c b/send.c
index 673f0748..5f4703c2 100644
--- a/send.c
+++ b/send.c
@@ -1323,9 +1323,13 @@ static int postpone_message (HEADER *msg, HEADER *cur, char *fcc, int flags)
   char *pgpkeylist = NULL;
   char *encrypt_as = NULL;
   int is_signed;
+  BODY *clear_content = NULL;
 
-  if (!Postponed)
+  if (!(Postponed && *Postponed))
+  {
+    mutt_error _("Can not postpone.  $postponed is unset");
     return -1;
+  }
 
   if (msg->content->next)
     msg->content = mutt_make_multipart (msg->content);
@@ -1348,6 +1352,7 @@ static int postpone_message (HEADER *msg, HEADER *cur, char *fcc, int flags)
         msg->security &= ~SIGN;
 
       pgpkeylist = safe_strdup (encrypt_as);
+      clear_content = msg->content;
       if (mutt_protect (msg, pgpkeylist) == -1)
       {
         if (is_signed)
@@ -1379,13 +1384,22 @@ static int postpone_message (HEADER *msg, HEADER *cur, char *fcc, int flags)
                       (cur && (flags & SENDREPLY)) ? cur->env->message_id : NULL,
                       1, fcc) < 0)
   {
+    if (clear_content)
+    {
+      mutt_free_body (&msg->content);
+      msg->content = clear_content;
+    }
     msg->content = mutt_remove_multipart (msg->content);
     decode_descriptions (msg->content);
     mutt_unprepare_envelope (msg->env);
     return -1;
   }
+
   mutt_update_num_postponed ();
 
+  if (clear_content)
+    mutt_free_body (&clear_content);
+
   return 0;
 }