From: Bart House <bart@barthouse.com>
Date: Thu, 22 Nov 2018 18:15:43 +0000 (-0800)
Subject: Removed unnecessary use of static for nocreate values.
X-Git-Tag: NetHack-3.6.2_Released~161^2~63
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=74fc1403e308fef55768ab44e72f6a8074cc3458;p=nethack

Removed unnecessary use of static for nocreate values.

If multiple games are played without exiting the process, on the second
new player creation the nocreate values will already be set based
on the first player creation.
---

diff --git a/src/u_init.c b/src/u_init.c
index 5b5c5113f..71da5a84a 100644
--- a/src/u_init.c
+++ b/src/u_init.c
@@ -974,15 +974,16 @@ register struct trobj *trop;
     struct obj *obj;
     int otyp, i;
 
-    while (trop->trclass) {
+	NEARDATA short nocreate = STRANGE_OBJECT;
+	NEARDATA short nocreate2 = STRANGE_OBJECT;
+	NEARDATA short nocreate3 = STRANGE_OBJECT;
+	NEARDATA short nocreate4 = STRANGE_OBJECT;
+
+	while (trop->trclass) {
         otyp = (int) trop->trotyp;
         if (otyp != UNDEF_TYP) {
             obj = mksobj(otyp, TRUE, FALSE);
         } else { /* UNDEF_TYP */
-            static NEARDATA short nocreate = STRANGE_OBJECT;
-            static NEARDATA short nocreate2 = STRANGE_OBJECT;
-            static NEARDATA short nocreate3 = STRANGE_OBJECT;
-            static NEARDATA short nocreate4 = STRANGE_OBJECT;
             /*
              * For random objects, do not create certain overly powerful
              * items: wand of wishing, ring of levitation, or the