From: Victor Stinner <victor.stinner@gmail.com>
Date: Wed, 28 Mar 2012 00:50:46 +0000 (+0200)
Subject: Document the fact that mach_timebase_info() cannot fail
X-Git-Tag: v3.3.0a2~33
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=74eb6c0e8bcdab65ac10f5a0a880768eef15a601;p=python

Document the fact that mach_timebase_info() cannot fail

And call mach_absolute_time() after mach_timebase_info().
---

diff --git a/Modules/timemodule.c b/Modules/timemodule.c
index b32c9df107..c99c0a934b 100644
--- a/Modules/timemodule.c
+++ b/Modules/timemodule.c
@@ -768,13 +768,17 @@ steady_clock(int strict)
 #if defined(MS_WINDOWS) && !defined(__BORLANDC__)
     return win32_clock(!strict);
 #elif defined(__APPLE__)
-    uint64_t time = mach_absolute_time();
+    static mach_timebase_info_data_t timebase;
+    uint64_t time;
     double secs;
 
-    static mach_timebase_info_data_t timebase;
-    if (timebase.denom == 0)
-      mach_timebase_info(&timebase);
+    if (timebase.denom == 0) {
+        /* According to the Technical Q&A QA1398, mach_timebase_info() cannot
+           fail: https://developer.apple.com/library/mac/#qa/qa1398/ */
+        (void)mach_timebase_info(&timebase);
+    }
 
+    time = mach_absolute_time();
     secs = (double)time * timebase.numer / timebase.denom * 1e-9;
 
     return PyFloat_FromDouble(secs);