From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Sun, 27 Mar 2022 02:39:53 +0000 (-0700)
Subject: remove 'WIN32_LEAN_AND_MEAN' manipulation
X-Git-Tag: 4.0.0~149^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=73eb297da2e25991fe82530dbd6bb8f4bd4b11ab;p=graphviz

remove 'WIN32_LEAN_AND_MEAN' manipulation

This macro is a legacy toggle to suppress parts of the Windows API surface in
order to accelerate compilation. In a parallel compilation of a code base the
size of Graphviz, it has a negligible effect. As always, Raymond Chen gives the
back story.¹ This commit removes these tricks to ease future maintenance.

¹ https://devblogs.microsoft.com/oldnewthing/20091130-00/?p=15863
---

diff --git a/cmd/smyrna/main.c b/cmd/smyrna/main.c
index 7f531fe82..e312528c6 100644
--- a/cmd/smyrna/main.c
+++ b/cmd/smyrna/main.c
@@ -13,7 +13,6 @@
 #include "builddate.h"
 //windows.h for win machines
 #if defined(_WIN32) && !defined(__CYGWIN__)
-#define WIN32_LEAN_AND_MEAN 1
 #include <windows.h>
 #include <windowsx.h>
 #endif
diff --git a/tclpkg/tkspline/dllEntry.c b/tclpkg/tkspline/dllEntry.c
index 493f9a5b4..f73ac3bb8 100644
--- a/tclpkg/tkspline/dllEntry.c
+++ b/tclpkg/tkspline/dllEntry.c
@@ -12,9 +12,7 @@
  *	dllEntry.c
  */
 
-#define WIN32_LEAN_AND_MEAN
 #include <windows.h>
-#undef WIN32_LEAN_AND_MEAN
 
 /*
  * The following declarations are for the Borland and VC++
diff --git a/windows/gvedit/USettings.cpp b/windows/gvedit/USettings.cpp
index d6b084f77..ef43c1016 100644
--- a/windows/gvedit/USettings.cpp
+++ b/windows/gvedit/USettings.cpp
@@ -2,7 +2,6 @@
 
 #include <shlobj.h>
 
-#define NO_WIN32_LEAN_AND_MEAN 1
 #include <vcl.h>
 #pragma hdrstop