From: Neal Norwitz <nnorwitz@gmail.com>
Date: Wed, 25 Jan 2006 05:42:22 +0000 (+0000)
Subject: mwh pointed out _Filemodule.c is generated. So to fix the memory leak
X-Git-Tag: v2.5a0~743
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=73afe9aa32b8513c6d4c4d0ee24ed87fb64638ec;p=python

mwh pointed out _Filemodule.c is generated. So to fix the memory leak
this file (the source) must be fixed.

Why isn't there a comment at the top saying the file is generated and
why are both the source and generated file checked in?  Bootstrap problem?

Will backport.
---

diff --git a/Mac/Modules/file/filesupport.py b/Mac/Modules/file/filesupport.py
index d0e88f016f..f2d419328b 100644
--- a/Mac/Modules/file/filesupport.py
+++ b/Mac/Modules/file/filesupport.py
@@ -302,11 +302,10 @@ PyMac_GetFSRef(PyObject *v, FSRef *fsr)
                 char *path = NULL;
                 if (!PyArg_Parse(v, "et", Py_FileSystemDefaultEncoding, &path))
                         return 0;
-                if ( (err=FSPathMakeRef(path, fsr, NULL)) ) {
+                if ( (err=FSPathMakeRef(path, fsr, NULL)) )
                         PyMac_Error(err);
-                        return 0;
-                }
-                return 1;
+                PyMem_Free(path);
+                return !err;
         }
         /* XXXX Should try unicode here too */
         /* Otherwise we try to go via an FSSpec */